1284380 - Bugzilla should set Cache-Control: private on all requests (until we can do something more flexible)

Status: NEW

(bugzilla.mozilla.org :: General, enhancement, P5)

Description

[Dylan Hardison [:dylan] (he/him)]

If a bugzilla user wants to run it behind a CDN like fastly, the reverse proxy may cache the result of show_bug.cgi, including show_bug.cgi on a private bug. 
Setting Cache-Control: private in $cgi->header() should alleviate this.

However if Cache-Control is already set, nothing should be done. Hopefully we can begin to do even smarter things so that bugzilla sites can run behind fast CDNs.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

The code in question would be https://github.com/bugzilla/bugzilla/blob/master/Bugzilla/CGI.pm#L275-L345
CGI.pm does some name mangling, so the value would be $headers{Cache_Control}.

Comment 2

[Hamzah Akhtar]

Hey! I would like to work on this bug. As this bug is my first, can someone guide me, as to where should I start from?

Comment 3

[Firefox Bug Husbandry Bot]

Removing good-first-bug keyword because team does not have bandwidth to mentor at the moment.

Comment 4

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request by dylan

Comment 5

[Muhammad A.G. Bello]

I would love to give this bug a go. Could it be assigned to me, please?