[TSF] Kakutei-Undo doesn't work on Facebook (comment field)

NEW
Unassigned

Status

()

Core
Widget: Win32
P3
normal
2 years ago
2 years ago

People

(Reporter: masayuki, Unassigned)

Tracking

(Blocks: 1 bug, {inputmethod})

Trunk
All
Windows
inputmethod
Points:
---

Firefox Tracking Flags

(platform-rel -, firefox50 affected)

Details

(Whiteboard: tpi:+ [platform-rel-Facebook])

On Facebook, I cannot use Kakutei-undo. This might not be TSF specific, though.

After unlocking the document, focus change occurs:
> [Main Thread]: D/nsTextStoreWidgets TSF:   TSFTextStore::OnFocusChange(aGotFocus=false, aFocusedWidget=0x1d84552a800, aContext={ mIMEState={ mEnabled=ENABLED }, mHTMLInputType="" }), sThreadMgr=0x1d83eda5780, sEnabledTextStore=0x1d842bf6280
> [Main Thread]: I/nsTextStoreWidgets TSF: 0x1d842bf6280 TSFTextStore::Destroy(), mLock=not-specified, mComposition.IsComposing()=false, mHandlingKeyMessage=0
> [Main Thread]: D/nsTextStoreWidgets TSF: 0x1d842bf6280   TSFTextStore::Destroy(), calling ITextStoreACPSink::OnLayoutChange(TS_LC_DESTROY)...
> [Main Thread]: I/nsTextStoreWidgets TSF: 0x1d842bf6280 TSFTextStore::RequestLock(dwLockFlags=TS_LF_READ, phrSession=0x25fdffc840), mLock=not-specified, mDestroyed=true
> [Main Thread]: E/nsTextStoreWidgets TSF: 0x1d842bf6280   TSFTextStore::RequestLock() FAILED due to being destroyed and no information of the contents
> [Main Thread]: I/nsTextStoreWidgets TSF: 0x1d842bf6280 TSFTextStore::ReleaseTSFObjects()
> [Main Thread]: I/nsTextStoreWidgets TSF: 0x1d842bf6280 TSFTextStore::UnadviseSink(punk=0x1d84d4d0458), mSink=0x1d84d4d0458
> [Main Thread]: D/nsTextStoreWidgets TSF: 0x1d842bf6280   TSFTextStore::ReleaseTSFObjects(), removing a mouse tracker...
> [Main Thread]: D/nsTextStoreWidgets TSF: 0x1d842bf6280   TSFTextStore::ReleaseTSFObjects() completed
> [Main Thread]: I/nsTextStoreWidgets TSF: 0x1d842bf6280   TSFTextStore::Destroy() succeeded
> [Main Thread]: I/nsTextStoreWidgets TSF: 0x1d842bf6280 TSFTextStore instance is destroyed
> [Main Thread]: D/nsTextStoreWidgets TSF: TSFTextStore::SetInputContext(aWidget=1d84552a800, aContext.mIMEState.mEnabled=DISABLED, aAction.mFocusChange=LOST_FOCUS), sEnabledTextStore=0x0, ThinksHavingFocus()=false
> [Main Thread]: D/nsTextStoreWidgets TSF: TSFTextStore::SetInputContext(aWidget=1d84552a800, aContext.mIMEState.mEnabled=DISABLED, aAction.mFocusChange=LOST_FOCUS), sEnabledTextStore=0x0, ThinksHavingFocus()=false
> [Main Thread]: D/nsTextStoreWidgets TSF: TSFTextStore::SetInputContext(aWidget=1d84552a800, aContext.mIMEState.mEnabled=ENABLED, aAction.mFocusChange=GOT_FOCUS), sEnabledTextStore=0x0, ThinksHavingFocus()=false
> [Main Thread]: D/nsTextStoreWidgets TSF:   TSFTextStore::OnFocusChange(aGotFocus=true, aFocusedWidget=0x1d84552a800, aContext={ mIMEState={ mEnabled=ENABLED }, mHTMLInputType="" }), sThreadMgr=0x1d83eda5780, sEnabledTextStore=0x0

This must be the cause. I guess that if we can prevent unnecessary focus change (not actually moving focus), we can avoid this issue and reduce a lot of run time cost. For example, TSFTextStore doesn't need to recreate all TSF objects at every composition commit.

Updated

2 years ago
Priority: -- → P3
Whiteboard: tpi:+
platform-rel: --- → ?
Whiteboard: tpi:+ → tpi:+ [platform-rel-Facebook]

Updated

2 years ago
platform-rel: ? → -
You need to log in before you can comment on or make changes to this bug.