Closed Bug 1284422 Opened 8 years ago Closed 8 years ago

Remove unnecessary prefix from MOZ_LOG() in IME related code since current MOZ_LOG appends log module name to each line

Categories

(Core :: Widget, defect)

Product:
Core
Component:
Widget
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

(Keywords: inputmethod)

Attachments

(11 files)

Bug 1284422 part.1 Remove "TSF: " from log of TSFTextStore.cpp
58 bytes, text/x-review-board-request
m_kato
: review+
Details
Bug 1284422 part.2 Fix odd indent of MOZ_LOG() in TSFTextStore.cpp (mainly caused by replacing from PR_LOG())
58 bytes, text/x-review-board-request
m_kato
: review+
Details
Bug 1284422 part.3 Remove "IMM: " from log of IMMHandler.cpp
58 bytes, text/x-review-board-request
m_kato
: review+
Details
Bug 1284422 part.4 Fix odd indent of MOZ_LOG() in TextInputHandler.mm
58 bytes, text/x-review-board-request
m_kato
: review+
Details
Bug 1284422 part.5 Remove "GTKIM: " from log of IMContextWrapper.cpp
58 bytes, text/x-review-board-request
m_kato
: review+
Details
Bug 1284422 part.6 Reduce indent of MOZ_LOG() in IMContextWrapper.cpp
58 bytes, text/x-review-board-request
m_kato
: review+
Details
Bug 1284422 part.7 Replace "KeymapWrapper(%p): " with "0x%p " and "%p" with "0x%p" in nsGtkKeyUtils.cpp
58 bytes, text/x-review-board-request
m_kato
: review+
Details
Bug 1284422 part.8 Fix odd indent of MOZ_LOG() in nsGtkKeyUtils.cpp (mainly caused by replacing from PR_LOG())
58 bytes, text/x-review-board-request
m_kato
: review+
Details
Bug 1284422 part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current design
58 bytes, text/x-review-board-request
m_kato
: review+
Details
Bug 1284422 part.10 Remove "IMCO: " from log of IMEContentObserver.cpp
58 bytes, text/x-review-board-request
m_kato
: review+
Details
Bug 1284422 part.11 Remove "IMS: " and "IMEStateManager::" from log of IMEStateManager.cpp
58 bytes, text/x-review-board-request
m_kato
: review+
Details 
Now, all IME related logs use LazyLogModule. In this case, each line starts with the log module name. Therefore, now, each log's prefix like "TSF: " isn't necessary. We should remove them.
Review commit: https://reviewboard.mozilla.org/r/62316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62316/
Attachment #8767927 - Flags: review?(m_kato)
Attachment #8767928 - Flags: review?(m_kato)
Attachment #8767929 - Flags: review?(m_kato)
Attachment #8767930 - Flags: review?(m_kato)
Attachment #8767931 - Flags: review?(m_kato)
Attachment #8767932 - Flags: review?(m_kato)
Attachment #8767933 - Flags: review?(m_kato)
Attachment #8767934 - Flags: review?(m_kato)
Attachment #8767936 - Flags: review?(m_kato)
Attachment #8767937 - Flags: review?(m_kato)
Attachment #8767935 - Flags: review?(m_kato)
Attachment #8767927 - Flags: review?(m_kato) → review+
Comment on attachment 8767927 [details]
Bug 1284422 part.1 Remove "TSF: " from log of TSFTextStore.cpp

https://reviewboard.mozilla.org/r/62316/#review59278
Attachment #8767928 - Flags: review?(m_kato) → review+
Comment on attachment 8767928 [details]
Bug 1284422 part.2 Fix odd indent of MOZ_LOG() in TSFTextStore.cpp (mainly caused by replacing from PR_LOG())

https://reviewboard.mozilla.org/r/62318/#review59304
Comment on attachment 8767929 [details]
Bug 1284422 part.3 Remove "IMM: " from log of IMMHandler.cpp

https://reviewboard.mozilla.org/r/62320/#review59310
Attachment #8767929 - Flags: review?(m_kato) → review+
Attachment #8767930 - Flags: review?(m_kato) → review+
Comment on attachment 8767930 [details]
Bug 1284422 part.4 Fix odd indent of MOZ_LOG() in TextInputHandler.mm

https://reviewboard.mozilla.org/r/62322/#review59312
Comment on attachment 8767931 [details]
Bug 1284422 part.5 Remove "GTKIM: " from log of IMContextWrapper.cpp

https://reviewboard.mozilla.org/r/62324/#review59324
Attachment #8767931 - Flags: review?(m_kato) → review+
Comment on attachment 8767932 [details]
Bug 1284422 part.6 Reduce indent of MOZ_LOG() in IMContextWrapper.cpp

https://reviewboard.mozilla.org/r/62326/#review59326
Attachment #8767932 - Flags: review?(m_kato) → review+
Comment on attachment 8767933 [details]
Bug 1284422 part.7 Replace "KeymapWrapper(%p): " with "0x%p " and "%p" with "0x%p" in nsGtkKeyUtils.cpp

https://reviewboard.mozilla.org/r/62328/#review59328
Attachment #8767933 - Flags: review?(m_kato) → review+
Comment on attachment 8767934 [details]
Bug 1284422 part.8 Fix odd indent of MOZ_LOG() in nsGtkKeyUtils.cpp (mainly caused by replacing from PR_LOG())

https://reviewboard.mozilla.org/r/62330/#review59330
Attachment #8767934 - Flags: review?(m_kato) → review+
Comment on attachment 8767935 [details]
Bug 1284422 part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current design

https://reviewboard.mozilla.org/r/62332/#review59334
Attachment #8767935 - Flags: review?(m_kato) → review+
https://reviewboard.mozilla.org/r/62328/#review59336

nit: replace %p with 0x%p

::: widget/gtk/nsGtkKeyUtils.cpp:168
(Diff revision 1)
>      mInitialized(false), mGdkKeymap(gdk_keymap_get_default()),
>      mXKBBaseEventCode(0)
>  {
>      MOZ_LOG(gKeymapWrapperLog, LogLevel::Info,
> -        ("KeymapWrapper(%p): Constructor, mGdkKeymap=%p",
> +        ("%p Constructor, mGdkKeymap=%p",
>           this, mGdkKeymap));

other pathes use 0x%p, but these fixes use %p.  I think that you should replace all %p with 0x%p
Attachment #8767936 - Flags: review?(m_kato) → review+
Comment on attachment 8767936 [details]
Bug 1284422 part.10 Remove "IMCO: " from log of IMEContentObserver.cpp

https://reviewboard.mozilla.org/r/62334/#review59338
Attachment #8767937 - Flags: review?(m_kato) → review+
Comment on attachment 8767937 [details]
Bug 1284422 part.11 Remove "IMS: " and "IMEStateManager::"  from log of IMEStateManager.cpp

https://reviewboard.mozilla.org/r/62336/#review59340
Comment on attachment 8767927 [details]
Bug 1284422 part.1 Remove "TSF: " from log of TSFTextStore.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62316/diff/1-2/
Attachment #8767933 - Attachment description: Bug 1284422 part.7 Replace "KeymapWrapper(%p): " with "%p " in nsGtkKeyUtils.cpp → Bug 1284422 part.7 Replace "KeymapWrapper(%p): " with "0x%p " and "%p" with "0x%p" in nsGtkKeyUtils.cpp
Attachment #8767935 - Attachment description: Bug 1284422 part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current designr?m_kato → Bug 1284422 part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current design
Comment on attachment 8767928 [details]
Bug 1284422 part.2 Fix odd indent of MOZ_LOG() in TSFTextStore.cpp (mainly caused by replacing from PR_LOG())

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62318/diff/1-2/
Comment on attachment 8767929 [details]
Bug 1284422 part.3 Remove "IMM: " from log of IMMHandler.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62320/diff/1-2/
Comment on attachment 8767930 [details]
Bug 1284422 part.4 Fix odd indent of MOZ_LOG() in TextInputHandler.mm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62322/diff/1-2/
Comment on attachment 8767931 [details]
Bug 1284422 part.5 Remove "GTKIM: " from log of IMContextWrapper.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62324/diff/1-2/
Comment on attachment 8767932 [details]
Bug 1284422 part.6 Reduce indent of MOZ_LOG() in IMContextWrapper.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62326/diff/1-2/
Comment on attachment 8767933 [details]
Bug 1284422 part.7 Replace "KeymapWrapper(%p): " with "0x%p " and "%p" with "0x%p" in nsGtkKeyUtils.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62328/diff/1-2/
Comment on attachment 8767934 [details]
Bug 1284422 part.8 Fix odd indent of MOZ_LOG() in nsGtkKeyUtils.cpp (mainly caused by replacing from PR_LOG())

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62330/diff/1-2/
Comment on attachment 8767935 [details]
Bug 1284422 part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current design

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62332/diff/1-2/
Comment on attachment 8767936 [details]
Bug 1284422 part.10 Remove "IMCO: " from log of IMEContentObserver.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62334/diff/1-2/
Comment on attachment 8767937 [details]
Bug 1284422 part.11 Remove "IMS: " and "IMEStateManager::"  from log of IMEStateManager.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62336/diff/1-2/
https://reviewboard.mozilla.org/r/62328/#review59336

> other pathes use 0x%p, but these fixes use %p.  I think that you should replace all %p with 0x%p

Done.
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/09d03ee4fd06
part.1 Remove "TSF: " from log of TSFTextStore.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/08e730cb01f0
part.2 Fix odd indent of MOZ_LOG() in TSFTextStore.cpp (mainly caused by replacing from PR_LOG()) r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ecde910f10a0
part.3 Remove "IMM: " from log of IMMHandler.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/532398e5766f
part.4 Fix odd indent of MOZ_LOG() in TextInputHandler.mm r=m_kato
https://hg.mozilla.org/integration/autoland/rev/20d68ac5d2b9
part.5 Remove "GTKIM: " from log of IMContextWrapper.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/924b9f0a3bb0
part.6 Reduce indent of MOZ_LOG() in IMContextWrapper.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/34a07555c050
part.7 Replace "KeymapWrapper(%p): " with "0x%p " and "%p" with "0x%p" in nsGtkKeyUtils.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/cf238281b89f
part.8 Fix odd indent of MOZ_LOG() in nsGtkKeyUtils.cpp (mainly caused by replacing from PR_LOG()) r=m_kato
https://hg.mozilla.org/integration/autoland/rev/9a7b0cdc1761
part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current design r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b12eb7caa712
part.10 Remove "IMCO: " from log of IMEContentObserver.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/70852530cdb5
part.11 Remove "IMS: " and "IMEStateManager::"  from log of IMEStateManager.cpp r=m_kato
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: