1284422 - Remove unnecessary prefix from MOZ_LOG() in IME related code since current MOZ_LOG appends log module name to each line

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, all IME related logs use LazyLogModule. In this case, each line starts with the log module name. Therefore, now, each log's prefix like "TSF: " isn't necessary. We should remove them.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c59396417c17

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.1 Remove "TSF: " from log of TSFTextStore.cpp

Review commit: https://reviewboard.mozilla.org/r/62316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62316/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.2 Fix odd indent of MOZ_LOG() in TSFTextStore.cpp (mainly caused by replacing from PR_LOG())

Review commit: https://reviewboard.mozilla.org/r/62318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62318/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.3 Remove "IMM: " from log of IMMHandler.cpp

Review commit: https://reviewboard.mozilla.org/r/62320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62320/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.4 Fix odd indent of MOZ_LOG() in TextInputHandler.mm

Review commit: https://reviewboard.mozilla.org/r/62322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62322/

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.5 Remove "GTKIM: " from log of IMContextWrapper.cpp

Review commit: https://reviewboard.mozilla.org/r/62324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62324/

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.6 Reduce indent of MOZ_LOG() in IMContextWrapper.cpp

Review commit: https://reviewboard.mozilla.org/r/62326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62326/

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.7 Replace "KeymapWrapper(%p): " with "0x%p " and "%p" with "0x%p" in nsGtkKeyUtils.cpp

Review commit: https://reviewboard.mozilla.org/r/62328/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62328/

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.8 Fix odd indent of MOZ_LOG() in nsGtkKeyUtils.cpp (mainly caused by replacing from PR_LOG())

Review commit: https://reviewboard.mozilla.org/r/62330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62330/

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current design

Review commit: https://reviewboard.mozilla.org/r/62332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62332/

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.10 Remove "IMCO: " from log of IMEContentObserver.cpp

Review commit: https://reviewboard.mozilla.org/r/62334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62334/

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1284422 part.11 Remove "IMS: " and "IMEStateManager::" from log of IMEStateManager.cpp

Review commit: https://reviewboard.mozilla.org/r/62336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62336/

Comment 13

[Makoto Kato [:m_kato]]

Comment on attachment 8767927 [details]
Bug 1284422 part.1 Remove "TSF: " from log of TSFTextStore.cpp

https://reviewboard.mozilla.org/r/62316/#review59278

Comment 14

[Makoto Kato [:m_kato]]

Comment on attachment 8767928 [details]
Bug 1284422 part.2 Fix odd indent of MOZ_LOG() in TSFTextStore.cpp (mainly caused by replacing from PR_LOG())

https://reviewboard.mozilla.org/r/62318/#review59304

Comment 15

[Makoto Kato [:m_kato]]

Comment on attachment 8767929 [details]
Bug 1284422 part.3 Remove "IMM: " from log of IMMHandler.cpp

https://reviewboard.mozilla.org/r/62320/#review59310

Comment 16

[Makoto Kato [:m_kato]]

Comment on attachment 8767930 [details]
Bug 1284422 part.4 Fix odd indent of MOZ_LOG() in TextInputHandler.mm

https://reviewboard.mozilla.org/r/62322/#review59312

Comment 17

[Makoto Kato [:m_kato]]

Comment on attachment 8767931 [details]
Bug 1284422 part.5 Remove "GTKIM: " from log of IMContextWrapper.cpp

https://reviewboard.mozilla.org/r/62324/#review59324

Comment 18

[Makoto Kato [:m_kato]]

Comment on attachment 8767932 [details]
Bug 1284422 part.6 Reduce indent of MOZ_LOG() in IMContextWrapper.cpp

https://reviewboard.mozilla.org/r/62326/#review59326

Comment 19

[Makoto Kato [:m_kato]]

Comment on attachment 8767933 [details]
Bug 1284422 part.7 Replace "KeymapWrapper(%p): " with "0x%p " and "%p" with "0x%p" in nsGtkKeyUtils.cpp

https://reviewboard.mozilla.org/r/62328/#review59328

Comment 20

[Makoto Kato [:m_kato]]

Comment on attachment 8767934 [details]
Bug 1284422 part.8 Fix odd indent of MOZ_LOG() in nsGtkKeyUtils.cpp (mainly caused by replacing from PR_LOG())

https://reviewboard.mozilla.org/r/62330/#review59330

Comment 21

[Makoto Kato [:m_kato]]

Comment on attachment 8767935 [details]
Bug 1284422 part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current design

https://reviewboard.mozilla.org/r/62332/#review59334

Comment 22

[Makoto Kato [:m_kato]]

https://reviewboard.mozilla.org/r/62328/#review59336

nit: replace %p with 0x%p

::: widget/gtk/nsGtkKeyUtils.cpp:168
(Diff revision 1)
>      mInitialized(false), mGdkKeymap(gdk_keymap_get_default()),
>      mXKBBaseEventCode(0)
>  {
>      MOZ_LOG(gKeymapWrapperLog, LogLevel::Info,
> -        ("KeymapWrapper(%p): Constructor, mGdkKeymap=%p",
> +        ("%p Constructor, mGdkKeymap=%p",
>           this, mGdkKeymap));

other pathes use 0x%p, but these fixes use %p.  I think that you should replace all %p with 0x%p

Comment 23

[Makoto Kato [:m_kato]]

Comment on attachment 8767936 [details]
Bug 1284422 part.10 Remove "IMCO: " from log of IMEContentObserver.cpp

https://reviewboard.mozilla.org/r/62334/#review59338

Comment 24

[Makoto Kato [:m_kato]]

Comment on attachment 8767937 [details]
Bug 1284422 part.11 Remove "IMS: " and "IMEStateManager::"  from log of IMEStateManager.cpp

https://reviewboard.mozilla.org/r/62336/#review59340

Comment 25

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d42fb1d8c74

Comment 26

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767927 [details]
Bug 1284422 part.1 Remove "TSF: " from log of TSFTextStore.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62316/diff/1-2/

Comment 27

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767928 [details]
Bug 1284422 part.2 Fix odd indent of MOZ_LOG() in TSFTextStore.cpp (mainly caused by replacing from PR_LOG())

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62318/diff/1-2/

Comment 28

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767929 [details]
Bug 1284422 part.3 Remove "IMM: " from log of IMMHandler.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62320/diff/1-2/

Comment 29

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767930 [details]
Bug 1284422 part.4 Fix odd indent of MOZ_LOG() in TextInputHandler.mm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62322/diff/1-2/

Comment 30

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767931 [details]
Bug 1284422 part.5 Remove "GTKIM: " from log of IMContextWrapper.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62324/diff/1-2/

Comment 31

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767932 [details]
Bug 1284422 part.6 Reduce indent of MOZ_LOG() in IMContextWrapper.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62326/diff/1-2/

Comment 32

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767933 [details]
Bug 1284422 part.7 Replace "KeymapWrapper(%p): " with "0x%p " and "%p" with "0x%p" in nsGtkKeyUtils.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62328/diff/1-2/

Comment 33

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767934 [details]
Bug 1284422 part.8 Fix odd indent of MOZ_LOG() in nsGtkKeyUtils.cpp (mainly caused by replacing from PR_LOG())

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62330/diff/1-2/

Comment 34

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767935 [details]
Bug 1284422 part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current design

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62332/diff/1-2/

Comment 35

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767936 [details]
Bug 1284422 part.10 Remove "IMCO: " from log of IMEContentObserver.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62334/diff/1-2/

Comment 36

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8767937 [details]
Bug 1284422 part.11 Remove "IMS: " and "IMEStateManager::"  from log of IMEStateManager.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62336/diff/1-2/

Comment 37

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://reviewboard.mozilla.org/r/62328/#review59336

> other pathes use 0x%p, but these fixes use %p.  I think that you should replace all %p with 0x%p

Done.

Comment 38

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09d03ee4fd06
part.1 Remove "TSF: " from log of TSFTextStore.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/08e730cb01f0
part.2 Fix odd indent of MOZ_LOG() in TSFTextStore.cpp (mainly caused by replacing from PR_LOG()) r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ecde910f10a0
part.3 Remove "IMM: " from log of IMMHandler.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/532398e5766f
part.4 Fix odd indent of MOZ_LOG() in TextInputHandler.mm r=m_kato
https://hg.mozilla.org/integration/autoland/rev/20d68ac5d2b9
part.5 Remove "GTKIM: " from log of IMContextWrapper.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/924b9f0a3bb0
part.6 Reduce indent of MOZ_LOG() in IMContextWrapper.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/34a07555c050
part.7 Replace "KeymapWrapper(%p): " with "0x%p " and "%p" with "0x%p" in nsGtkKeyUtils.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/cf238281b89f
part.8 Fix odd indent of MOZ_LOG() in nsGtkKeyUtils.cpp (mainly caused by replacing from PR_LOG()) r=m_kato
https://hg.mozilla.org/integration/autoland/rev/9a7b0cdc1761
part.9 Remove "ContentCache(InParent|InChild)?: " from log of ContentCache.cpp since the classes are not in same process under current design r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b12eb7caa712
part.10 Remove "IMCO: " from log of IMEContentObserver.cpp r=m_kato
https://hg.mozilla.org/integration/autoland/rev/70852530cdb5
part.11 Remove "IMS: " and "IMEStateManager::"  from log of IMEStateManager.cpp r=m_kato

Comment 39

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/09d03ee4fd06
https://hg.mozilla.org/mozilla-central/rev/08e730cb01f0
https://hg.mozilla.org/mozilla-central/rev/ecde910f10a0
https://hg.mozilla.org/mozilla-central/rev/532398e5766f
https://hg.mozilla.org/mozilla-central/rev/20d68ac5d2b9
https://hg.mozilla.org/mozilla-central/rev/924b9f0a3bb0
https://hg.mozilla.org/mozilla-central/rev/34a07555c050
https://hg.mozilla.org/mozilla-central/rev/cf238281b89f
https://hg.mozilla.org/mozilla-central/rev/9a7b0cdc1761
https://hg.mozilla.org/mozilla-central/rev/b12eb7caa712
https://hg.mozilla.org/mozilla-central/rev/70852530cdb5