Closed Bug 1284455 Opened 3 years ago Closed 3 years ago

[pine => m-c] Remove KillSwitch, SystemMessage, WebActivities APIs

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
Tracking Status
firefox50 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(4 files, 1 obsolete file)

No description provided.
Depends on: 1261013, 1261001
Summary: Remove KillSwitch API → Remove KillSwitch, SystemMessage and WebActivities APIs
Summary: Remove KillSwitch, SystemMessage and WebActivities APIs → [pine => m-c] Remove KillSwitch, SystemMessage and WebActivities APIs
Depends on: 1261011
Summary: [pine => m-c] Remove KillSwitch, SystemMessage and WebActivities APIs → [pine => m-c] Remove KillSwitch, SystemMessage, WebActivities and Inter-App Communnication APIs
IAC is already gone from m-c
No longer depends on: 1261011
Summary: [pine => m-c] Remove KillSwitch, SystemMessage, WebActivities and Inter-App Communnication APIs → [pine => m-c] Remove KillSwitch, SystemMessage, WebActivities APIs
Review commit: https://reviewboard.mozilla.org/r/62350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62350/
Attachment #8767949 - Flags: review?(lissyx+mozillians)
Attachment #8767950 - Flags: review?(lissyx+mozillians)
Attachment #8767951 - Flags: review?(lissyx+mozillians)
Comment on attachment 8767951 [details]
Bug 1284455 - Kill KillSwitch API

https://reviewboard.mozilla.org/r/62354/#review59070
Attachment #8767951 - Flags: review?(lissyx+mozillians) → review+
Comment on attachment 8767950 [details]
Bug 1284455 - Remove the System Messages API, Gecko part

https://reviewboard.mozilla.org/r/62352/#review59072
Attachment #8767950 - Flags: review?(lissyx+mozillians) → review+
Comment on attachment 8767949 [details]
Bug 1284455 - Remove the Web Activities API

https://reviewboard.mozilla.org/r/62350/#review59074
Attachment #8767949 - Flags: review?(lissyx+mozillians) → review+
Few conflicts, who were trivial to fix.
AudioChannel needs to scope-out SystemMessages until bug 1254282 is sent to central (but there are more conflicts to solve on that one, so it will wait)
Comment on attachment 8767963 [details]
Bug 1284455 - Kill uses of nsISystemMessagesInternal.h outside of b2g

https://reviewboard.mozilla.org/r/62360/#review59084

LGTM
Attachment #8767963 - Flags: review?(gsvelto) → review+
Comment on attachment 8767963 [details]
Bug 1284455 - Kill uses of nsISystemMessagesInternal.h outside of b2g

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62360/diff/1-2/
Comment on attachment 8767975 [details]
Bug 1284455 - Remove Web Activities from browser

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62362/diff/1-2/
Attachment #8767975 - Attachment description: Bug 1284455 - Remove MOZ_ACTIVITIES packaging from browser → Bug 1284455 - Remove Web Activities from browser
Attachment #8767975 - Flags: review?(gsvelto) → review?(mh+mozilla)
Blocks: 1284535
Comment on attachment 8767975 [details]
Bug 1284455 - Remove Web Activities from browser

https://reviewboard.mozilla.org/r/62362/#review59314

::: browser/installer/package-manifest.in
(Diff revision 2)
> -@RESPATH@/components/SystemMessageCache.js
> -@RESPATH@/components/SystemMessageInternal.js
> -@RESPATH@/components/SystemMessageManager.js
> -@RESPATH@/components/SystemMessageManager.manifest
> -
> -@RESPATH@/components/Activities.manifest
> -@RESPATH@/components/ActivityProxy.js
> -@RESPATH@/components/ActivityRequestHandler.js
> -@RESPATH@/components/ActivityWrapper.js
> -@RESPATH@/components/ActivityMessageConfigurator.js

Assuming these files are removed in the other patches, this one should land first, so that the state is not broken on intermediate steps.
Attachment #8767975 - Flags: review?(mh+mozilla) → review+
Sure, I will squash it into the proper bug to avoid broken state :)
Comment on attachment 8767949 [details]
Bug 1284455 - Remove the Web Activities API

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62350/diff/1-2/
Comment on attachment 8767950 [details]
Bug 1284455 - Remove the System Messages API, Gecko part

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62352/diff/1-2/
Comment on attachment 8767951 [details]
Bug 1284455 - Kill KillSwitch API

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62354/diff/1-2/
Comment on attachment 8767963 [details]
Bug 1284455 - Kill uses of nsISystemMessagesInternal.h outside of b2g

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62360/diff/2-3/
Attachment #8767975 - Attachment is obsolete: true
Comment on attachment 8767949 [details]
Bug 1284455 - Remove the Web Activities API

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62350/diff/2-3/
Comment on attachment 8767950 [details]
Bug 1284455 - Remove the System Messages API, Gecko part

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62352/diff/2-3/
Comment on attachment 8767951 [details]
Bug 1284455 - Kill KillSwitch API

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62354/diff/2-3/
Comment on attachment 8767963 [details]
Bug 1284455 - Kill uses of nsISystemMessagesInternal.h outside of b2g

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62360/diff/3-4/
(In reply to Mike Hommey [:glandium] from comment #20)
> Comment on attachment 8767975 [details]
> Bug 1284455 - Remove Web Activities from browser
> 
> https://reviewboard.mozilla.org/r/62362/#review59314
> 
> ::: browser/installer/package-manifest.in
> (Diff revision 2)
> > -@RESPATH@/components/SystemMessageCache.js
> > -@RESPATH@/components/SystemMessageInternal.js
> > -@RESPATH@/components/SystemMessageManager.js
> > -@RESPATH@/components/SystemMessageManager.manifest
> > -
> > -@RESPATH@/components/Activities.manifest
> > -@RESPATH@/components/ActivityProxy.js
> > -@RESPATH@/components/ActivityRequestHandler.js
> > -@RESPATH@/components/ActivityWrapper.js
> > -@RESPATH@/components/ActivityMessageConfigurator.js
> 
> Assuming these files are removed in the other patches, this one should land
> first, so that the state is not broken on intermediate steps.

Splitted in both patches to make sure we remove the files from the packaging at the same time that we delete them :)
Comment on attachment 8767949 [details]
Bug 1284455 - Remove the Web Activities API

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62350/diff/3-4/
Comment on attachment 8767950 [details]
Bug 1284455 - Remove the System Messages API, Gecko part

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62352/diff/3-4/
Comment on attachment 8767951 [details]
Bug 1284455 - Kill KillSwitch API

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62354/diff/3-4/
Comment on attachment 8767963 [details]
Bug 1284455 - Kill uses of nsISystemMessagesInternal.h outside of b2g

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62360/diff/4-5/
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/069a431e7053
Remove the Web Activities API r=me
https://hg.mozilla.org/integration/autoland/rev/1a5c34f5aa20
Remove the System Messages API, Gecko part r=me
https://hg.mozilla.org/integration/autoland/rev/f00d45823516
Kill KillSwitch API r=me
https://hg.mozilla.org/integration/autoland/rev/e172b816e847
Kill uses of nsISystemMessagesInternal.h outside of b2g r=gsvelto
This reduced the size of the Android apk by over 50K -- one of the most signficant improvements this month. Thanks!
Depends on: 1299400
You need to log in before you can comment on or make changes to this bug.