Closed
Bug 1284482
Opened 8 years ago
Closed 8 years ago
Remove useless parameters and variable declarations from _linkBrowserToTab and _createBrowser
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.88 KB,
patch
|
u462496
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8767965 -
Flags: review?(allassopraise)
Looks good. Can we go ahead and remove them in addTab `options` as well while we're at it?
let options = {
...
let { usingPreloadedContent } = this._linkBrowserToTab(t, aURI, options);Flags: needinfo?(dao+bmo)
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8767965 -
Attachment is obsolete: true
Attachment #8767965 -
Flags: review?(allassopraise)
Flags: needinfo?(dao+bmo)
Attachment #8768070 -
Flags: review?(allassopraise)
Attachment #8768070 -
Flags: review?(allassopraise) → review+
|
|
Assignee | |
Updated•8 years ago
|
Summary: Remove useless variable declarations from _linkBrowserToTab and _createBrowser → Remove useless parameters and variable declarations from _linkBrowserToTab and _createBrowser
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/5abbfd6f2779 Remove useless parameters and variable declarations from _linkBrowserToTab and _createBrowser. r=allassopraise
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5abbfd6f2779
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in
before you can comment on or make changes to this bug.
Description
•