1284488 - Json View / Response Tab should print values next to JSON tree

Status: RESOLVED WORKSFORME

(DevTools :: Netmonitor, enhancement, P2)

Description

[Jens]

Attachment: JSON_View_Firefox_vs_Chrome.png

See the attached screenshot. I had a long JSON and needed to find an *empty* Array in there. In the end I had to click through the whole JSON tree to find it. 

Instead of just printing "Array" or "Object" a preview of the actual JSON content should be printed right to each JSON node. (Also the shorter notations of [] and {} but be easier to read than "Array" and "Object")

This should work for the JSON Viewer (if enabled in about:config devtools.jsonview.enabled) when I open in a new tab. And also for the "Response" tab of the Network Monitor.

Chrome does it a bit better (again, see screenshot), but still has room for improvements:

- The tree annotations (e.g. keys, values, number, string, parentheses) should be syntax hightlighted in the same way the JS Debugger does

- The annotations line is quite short. There's lots of space not used on the right hand side.

I'm not sure, but this might be a candidate for [good first bug][lang=js] so it turns up as a starter bug on http://firefox-dev.tools/. Doesn't look too complicated to me.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I think these are great ideas!

Settting p2 since nobody is working on this now.
Honza

Comment 2

[Tim Nguyen :ntim]

Probably no longer relevant?

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: jsonview.png

I don't think we can close it yet. At least, I still need to click once to see that an array (or an object) is empty.

See the attached screenshot, by default `myarray` and `myobj` doesn't show any value.

It should be rendered like as follows by default:

myarray: []
myobj: {}

Honza

Comment 4

[Hemakshi Sachdev [:hemakshis]]

Attachment: response_json_view.png

Hi @honza,

I think that now we do show if an array or an object is empty or not.
In the screenshot above the array, b is empty and is shown as [] same for object e (shown as {}).

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yep, this can be closed.

Thanks for the note!

Honza