fork _nav_support_menu and move changes from bug 1231954 there

RESOLVED FIXED

Status

MozReview
Review Board: User Interface
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

when i reviewed bug 1231954 i forgot about:

"When making changes to a built-in review board template, forking the template file and changing the view to reference your new modified file is preferred - this will lessen merge conflicts when rebasing all of our changes on an updated RB (and allow us to integrate new upstream changes to the template in one go)"

let's revert _nav_support_menu and fork it here.
Created attachment 8767982 [details]
MozReview: revert changes from d1a3a686b1e0 (bug 1284494);

The changes made in bug 1231954 will be moved to a forked copy of that
template.

Review commit: https://reviewboard.mozilla.org/r/62366/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62366/
Attachment #8767982 - Flags: review?(smacleod)
Attachment #8767984 - Flags: review?(smacleod)
Created attachment 8767983 [details]
MozReview: fork _nav_support_menu template (bug 1284494)

Review commit: https://reviewboard.mozilla.org/r/62368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62368/
Created attachment 8767984 [details]
MozReview: Add link for keyboard shortcuts (bug 1284494)

Review commit: https://reviewboard.mozilla.org/r/62370/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62370/
Attachment #8767983 - Flags: review?(smacleod)
Comment on attachment 8767982 [details]
MozReview: revert changes from d1a3a686b1e0 (bug 1284494);

https://reviewboard.mozilla.org/r/62366/#review59200
Attachment #8767982 - Flags: review?(smacleod) → review+
Comment on attachment 8767983 [details]
MozReview: fork _nav_support_menu template (bug 1284494)

https://reviewboard.mozilla.org/r/62368/#review59202

"r?smmacleod" eh? Someone hasn't been using the draft state ;)
Attachment #8767983 - Flags: review?(smacleod) → review+
Comment on attachment 8767984 [details]
MozReview: Add link for keyboard shortcuts (bug 1284494)

https://reviewboard.mozilla.org/r/62370/#review59204
Attachment #8767984 - Flags: review?(smacleod) → review+

Comment 7

2 years ago
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/webtools/reviewboard/rev/31634fc85874
MozReview: revert changes from d1a3a686b1e0 ; r=smacleod
https://hg.mozilla.org/webtools/reviewboard/rev/53254c76f563
MozReview: fork _nav_support_menu template r=smacleod
https://hg.mozilla.org/webtools/reviewboard/rev/5d84ec273f3a
MozReview: Add link for keyboard shortcuts r=smacleod
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.