1284517 - The installer needs to update the lastWriteTime of the Firefox startmenu shortcut after bug 1232679

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1232679 added support for showing custom graphics and background colors for the start menu tiles on Windows 8 and 10. This will work fine for new installs but upgrading installs will need to have the lastwritetime of the Firefox start menu shortcut updated so Windows will update its cache.

See the bottom half of https://bugzilla.mozilla.org/show_bug.cgi?id=1232679#c13 for steps on how to do this with PowerShell.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1284517 - Touch the Start Menu shortcut on Windows 8 and later in the installer so the Start Menu tile cache gets cleared.

Review commit: https://reviewboard.mozilla.org/r/63260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63260/

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 8769291 [details]
Bug 1284517 - Touch the Start Menu shortcut on Windows 8 and later in the installer so the Start Menu tile cache gets cleared.

https://reviewboard.mozilla.org/r/63260/#review60092

This needs to happen during post update. Discussed this and a couple of other things with jaws over irc. Clearing review

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8769291 [details]
Bug 1284517 - Touch the Start Menu shortcut on Windows 8 and later in the installer so the Start Menu tile cache gets cleared.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63260/diff/1-2/

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 8769291 [details]
Bug 1284517 - Touch the Start Menu shortcut on Windows 8 and later in the installer so the Start Menu tile cache gets cleared.

https://reviewboard.mozilla.org/r/63260/#review60138

When I asked if you wanted to do this after an update I didn't mean that it shouldn't also be done on install.

Add the same code to the installer.nsi around here to handle pave over installs
https://dxr.mozilla.org/mozilla-central/source/browser/installer/windows/nsis/installer.nsi#544

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8769291 [details]
Bug 1284517 - Touch the Start Menu shortcut on Windows 8 and later in the installer so the Start Menu tile cache gets cleared.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63260/diff/2-3/

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 8769291 [details]
Bug 1284517 - Touch the Start Menu shortcut on Windows 8 and later in the installer so the Start Menu tile cache gets cleared.

https://reviewboard.mozilla.org/r/63260/#review60514

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0abc7b2bbc1f
Touch the Start Menu shortcut on Windows 8 and later in the installer so the Start Menu tile cache gets cleared. r=rstrong

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0abc7b2bbc1f

Comment 9

[Jim Jeffery not reading bug-mail 1/2/11]

I just installed the latest build with this patch from m-c tinderbox, and the Tile in start menu on win10 still have the light-blue color as I noted above.

I did a add/remove programs from Windows, then ran the .exe installer - so it appears that the cache perhaps did not clear.

Comment 10

[Jim Jeffery not reading bug-mail 1/2/11]

Restarted Win10, and Tile did not change, still light blue.

Comment 11

[Jim Jeffery not reading bug-mail 1/2/11]

I have just now unpinned/reinstalled/re-pinned to Start Menu, and the Tile background is still Light-Blue.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #11)
> I have just now unpinned/reinstalled/re-pinned to Start Menu, and the Tile
> background is still Light-Blue.

Can you please file a new bug and we'll continue the investigation there?

Comment 13

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #12)
> (In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #11)
> > I have just now unpinned/reinstalled/re-pinned to Start Menu, and the Tile
> > background is still Light-Blue.
> 
> Can you please file a new bug and we'll continue the investigation there?

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1286511

Comment 14

[Richard Marti (:Paenglab)]

Updating from a previous build, no matter if it's FX 49 or 50.0a1 doesn't update the icon in start menu on Win 8 nor Win 10. Only with an installer FX the icon is updated. I waited until now to be sure bug 1286511 doesn't interfere.

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

Did I miss the part of the updater to touch the shortcut?

Comment 16

[Robert Strong (they/them - no direct email)]

The code hits the post update path. It might need to check and update the shortcut for both the all users and the current user locations.

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #16)
> The code hits the post update path. It might need to check and update the
> shortcut for both the all users and the current user locations.

Filed bug 1291331.