Make NS_CompareLoadInfoAndLoadContext only compare OriginAttributes

NEW
Unassigned

Status

()

P3
normal
2 years ago
a year ago

People

(Reporter: jandreou25, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
With recent OriginAttributes changes all the previously compared information is now contained in OA. From the discussion in 1282124 an OA compare would be much cleaner.
(Reporter)

Comment 1

2 years ago
Created attachment 8768002 [details] [diff] [review]
Bug1284518.patch

Everything is fine with local tests and on try server. There may be non obvious things that break.
(Reporter)

Updated

2 years ago
Assignee: nobody → jandreou
Depends on: 1282124
(Reporter)

Updated

2 years ago
Attachment #8768002 - Flags: review?(amarchesini)
Comment on attachment 8768002 [details] [diff] [review]
Bug1284518.patch

Review of attachment 8768002 [details] [diff] [review]:
-----------------------------------------------------------------

f+. I'm not a necko peer. Valentin, can you help us with this?
Attachment #8768002 - Flags: review?(valentin.gosu)
Attachment #8768002 - Flags: review?(amarchesini)
Attachment #8768002 - Flags: feedback+
Comment on attachment 8768002 [details] [diff] [review]
Bug1284518.patch

Review of attachment 8768002 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great! r=valentin
Thanks!
Attachment #8768002 - Flags: review?(valentin.gosu) → review+
(Reporter)

Updated

2 years ago
Assignee: jandreou25 → nobody
Hi Andrew, I guess P3 would be a fit for now, but want to confirm if there's a plan on this.
Flags: needinfo?(overholt)
I think James wants to take this once he's got time but P3 is good for now.
Flags: needinfo?(overholt)
Priority: -- → P3

Comment 6

2 years ago
Michael, can you please help drive this to the finish line?  Thanks!
Flags: needinfo?(michael)
I don't think I will be able to get around to this anytime soon.
Flags: needinfo?(michael)
You need to log in before you can comment on or make changes to this bug.