1284518 - Make NS_CompareLoadInfoAndLoadContext only compare OriginAttributes

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[James Andreou]

With recent OriginAttributes changes all the previously compared information is now contained in OA. From the discussion in 1282124 an OA compare would be much cleaner.

Comment 1

[James Andreou]

Attachment: Bug1284518.patch

Everything is fine with local tests and on try server. There may be non obvious things that break.

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8768002 [details] [diff] [review]
Bug1284518.patch

Review of attachment 8768002 [details] [diff] [review]:
-----------------------------------------------------------------

f+. I'm not a necko peer. Valentin, can you help us with this?

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8768002 [details] [diff] [review]
Bug1284518.patch

Review of attachment 8768002 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great! r=valentin
Thanks!

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Andrew, I guess P3 would be a fit for now, but want to confirm if there's a plan on this.

Comment 5

[Andrew Overholt [:overholt]]

I think James wants to take this once he's got time but P3 is good for now.

Comment 6

[(no longer active)]

Michael, can you please help drive this to the finish line?  Thanks!

Comment 7

[Nika Layzell [:nika] (ni? for response)]

I don't think I will be able to get around to this anytime soon.