1284523 - Intermittent canvas/text-ltr-alignment-test.html == canvas/text-ltr-alignment-ref.html | (LOAD ONLY), max difference: 255, number of differing pixels: 1038

Status: RESOLVED DUPLICATE of bug 1285263

(Core :: Graphics: Canvas2D, defect)

Description

[Treeherder Bug Filer]

Filed by: [e-mail]

https://treeherder.mozilla.org/logviewer.html#?job_id=31192988&repo=mozilla-inbound

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-pgo/1467698033/mozilla-inbound_win7_ix_test_pgo-reftest-no-accel-e10s-bm119-tests1-windows-build4.txt.gz

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-pgo/1467698033/mozilla-inbound_win7_ix_test_pgo-reftest-no-accel-e10s-bm119-tests1-windows-build4.txt.gz&only_show_unexpected=1

Comment 1

[Bas Schouten (:bas.schouten)]

Well this is interesting... I have no idea how this would be intermittent. Jonathan, I believe we changed some Canvas text things recently, do you think this might be related?

Comment 2

[Jonathan Kew [:jfkthame]]

I don't think so. It looks like the testcase simply failed to draw anything, but I don't see how the recent canvas text changes would affect that. We still create the same textrun; we just switched to using the standard gfxTextRun::Draw codepath to render the glyphs instead of manually looping over them in the CanvasRenderingContext code.

Comment 3

[Bas Schouten (:bas.schouten)]

(In reply to Jonathan Kew (:jfkthame) from comment #2)
> I don't think so. It looks like the testcase simply failed to draw anything,
> but I don't see how the recent canvas text changes would affect that. We
> still create the same textrun; we just switched to using the standard
> gfxTextRun::Draw codepath to render the glyphs instead of manually looping
> over them in the CanvasRenderingContext code.

Yeah, that's the only change I can find though in the Canvas text rendering code. I wonder if this could be a regression from bug 1167235, but I'd expect more tests to be affected.

Comment 4

[Jonathan Kew [:jfkthame]]

I just saw bug 1285263, which sounds like it could be the same issue and has a regression range that points to bug 1167235.

Comment 5

[Nicolas Silva [:nical]]

Bug 1285263, just landed and, as Jonathan, I think this is the same issue, so it should be fixed as well now. Please reopen if the bug shows up again.