Review comment doesn't correlate to diff in mozReview

RESOLVED INVALID

Status

RESOLVED INVALID
2 years ago
2 years ago

People

(Reporter: jib, Unassigned)

Tracking

Details

Not sure how padenot did it, but this comment:

https://reviewboard.mozilla.org/r/59654/#comment76572

was somehow made on changees that are not in the diff range it purports to be a comment on.

The change being commented on (search for ".erase") is instead in a much earlier patch in the same queue: https://reviewboard.mozilla.org/r/58492/diff/2-3/

I should note I did add an extra patch set in the middle, and I've also inserted a couple of commits locally ahead of this review (I used hg push -r a::b review to omit it), but otherwise didn't rebase master during review.
By the last comment I meant I didn't pull from central. I did lots and lots of hg amend and hg histedit on the patch queue itself however.
Pilot error. I must have confused myself this morning.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.