Closed Bug 1284587 Opened 3 years ago Closed 3 years ago

Distinguish reader view items in bookmarks panel telemetry

Categories

(Firefox for Android Graveyard :: Reading List, defect, P1)

defect

Tracking

(firefox49 fixed, firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: ahunt, Assigned: ahunt)

Details

Attachments

(1 file)

When opening a bookmark we don't distinguish between normal bookmarks, and offline reader view bookmarks.

We could potentially also distinguish screenshots too (bug 1251058), but they're exclusively in their own folder, so perhaps that's not necessary (whereas reader view items can be in the root folder).
Assignee: nobody → ahunt
We want to be able to detect when we've opened a reader view item. Note: this is
independent of whether or not we're in the Reading List smartfolder: it's possible
to open reader view bookmarks from any real bookmark folder, or the smartfolder.

Review commit: https://reviewboard.mozilla.org/r/62544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62544/
Attachment #8768217 - Flags: review?(liuche)
Attachment #8768217 - Flags: review?(liuche) → review+
Comment on attachment 8768217 [details]
Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry

https://reviewboard.mozilla.org/r/62544/#review60460
Looks like we can land this? I'll set this to P1.
Priority: -- → P1
Yes, please this needs to go in asap. We need this for KPI measuring and to give some data to marketing (before/after). Thanks
Flags: needinfo?(s.kaspari)
https://hg.mozilla.org/integration/fx-team/rev/d70bb3bdb5cc14df566cc1ed2c12f38e184a2f54
Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry r=liuche
Flags: needinfo?(s.kaspari)
https://hg.mozilla.org/mozilla-central/rev/d70bb3bdb5cc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment on attachment 8768217 [details]
Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: no user impact. Telemetry impact: we will be unable to distinguish loading of normal vs reader-view bookmarks after the reading list migration.
[Describe test coverage new/current, TreeHerder]: manual testing, patch has been on nightly for past 2 weeks.
[Risks and why]: Low risk minor change to telemetry probe to send different "extra" when opening reader view bookmarks.
[String/UUID change made/needed]: None.
Attachment #8768217 - Flags: approval-mozilla-beta?
Comment on attachment 8768217 [details]
Bug 1284587 - Distinguish normal from reader view bookmarks in telemetry

This patch can help to collect data after the reading list migration. Take it in 49 beta. Should be in 49 beta 2.
Attachment #8768217 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.