Closed Bug 1284599 Opened 3 years ago Closed 3 years ago

Get rid of NS_IMPL_REFCNT_LOGGING

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(2 files)

nsTraceRefCnt.cpp has a bunch of things guarded with this #ifdef, but it is unconditionally defined at the top of the file. We should just get rid of it to make the file easier to read. It looks like there used to be an undef of this on WINCE but that is long gone.
Assignee: nobody → continuation
This is unconditionally true, going back to maybe the removal of #ifdef WINCE code.

This compiles locally, at least.
Attachment #8768135 - Flags: review?(nfroyd)
This doesn't add comments for all of them, just some of those spread out over many lines. The lack of these comments made writing part 1 more annoying.
Attachment #8768136 - Flags: review?(nfroyd)
Attachment #8768135 - Flags: review?(nfroyd) → review+
Comment on attachment 8768136 [details] [diff] [review]
part 2 - Add some more comments for #endif.

Review of attachment 8768136 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, C-c C-u will move you outside #if conditionals, and C-c C-n/C-p will move past conditionals; unsure if that would make things any less annoying.
Attachment #8768136 - Flags: review?(nfroyd) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eea8a7540e97
part 1 - Get rid of NS_IMPL_REFCNT_LOGGING. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef03c432e089
part 2 - Add some more comments for #endif. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/eea8a7540e97
https://hg.mozilla.org/mozilla-central/rev/ef03c432e089
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.