1284599 - Get rid of NS_IMPL_REFCNT_LOGGING

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

nsTraceRefCnt.cpp has a bunch of things guarded with this #ifdef, but it is unconditionally defined at the top of the file. We should just get rid of it to make the file easier to read. It looks like there used to be an undef of this on WINCE but that is long gone.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Get rid of NS_IMPL_REFCNT_LOGGING.

This is unconditionally true, going back to maybe the removal of #ifdef WINCE code.

This compiles locally, at least.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Add some more comments for #endif.

This doesn't add comments for all of them, just some of those spread out over many lines. The lack of these comments made writing part 1 more annoying.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8768136 [details] [diff] [review]
part 2 - Add some more comments for #endif.

Review of attachment 8768136 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, C-c C-u will move you outside #if conditionals, and C-c C-n/C-p will move past conditionals; unsure if that would make things any less annoying.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eea8a7540e97
part 1 - Get rid of NS_IMPL_REFCNT_LOGGING. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef03c432e089
part 2 - Add some more comments for #endif. r=froydnj

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eea8a7540e97
https://hg.mozilla.org/mozilla-central/rev/ef03c432e089