Closed Bug 1284617 Opened 8 years ago Closed 7 years ago

new live log viewer doesn't break lines as well as the old one

Categories

(Taskcluster :: UI, defect, P1)

Product:
Taskcluster
Component:
UI
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: delrio.andre, Mentored)

References

Details

I noticed this on https://tools.taskcluster.net/task-graph-inspector/#K0Fihhx4SNurUEEQrx8zZw/Hc0RyZgsRNGA2hQ2kle4Gw/0, which is a task that builds a Docker image. The usual progress bar output from Docker (which may use curses or some other way to update multiple parts of the screen) ends up all smushed together. The old log viewer created a new line when anything changed, which was a little better.
I've also noticed this in tasks that use curl to retrieve a file/artifact
Assignee: nobody → delrio.andre
Mentor: wcosta
Status: NEW → ASSIGNED
Priority: -- → P1
Probably a symptom of the same thing: the scroll bar gets misplaced. Eg: after some lines don't wrap properly, the scroll bar looks like it can scroll further, but it won't let me. There's also permanent empty space at the bottom of the log box that never gets text on it no matter how long the log gets.
Ben, can you share the task ID for that case please?
Flags: needinfo?(bhearsum)
(In reply to Andrea Del Rio from comment #3)
> Ben, can you share the task ID for that case please?

It exhibits that issue in the one linked from comment #0, but the most recent case is https://tools.taskcluster.net/task-graph-inspector/#MPQVdWpUSBugHsbf3o6_tQ/.
Flags: needinfo?(bhearsum)
I've also noticed it doesn't preserve multiple spaces, e.g. see livelog view:
  https://tools.taskcluster.net/task-inspector/#Oy_Y0dOvRcSk44tkEdTzQw/0

Now compare this to the raw log:
  https://public-artifacts.taskcluster.net/Oy_Y0dOvRcSk44tkEdTzQw/0/public/logs/live_backing.log

I'll raise a separate bug for this and link to it from this bug, but wanted to mention it here as maybe it has the same root cause...
See Also: → 1286804
(In reply to Pete Moore [:pmoore][:pete] from comment #5)
> I've also noticed it doesn't preserve multiple spaces, e.g. see livelog view:
>   https://tools.taskcluster.net/task-inspector/#Oy_Y0dOvRcSk44tkEdTzQw/0
> 
> Now compare this to the raw log:
>  
> https://public-artifacts.taskcluster.net/Oy_Y0dOvRcSk44tkEdTzQw/0/public/
> logs/live_backing.log
> 
> I'll raise a separate bug for this and link to it from this bug, but wanted
> to mention it here as maybe it has the same root cause...

Yes, it's all related, I have a PR opened to fix this.

https://github.com/taskcluster/taskcluster-tools/pull/119
Commit pushed to master at https://github.com/taskcluster/taskcluster-tools

https://github.com/taskcluster/taskcluster-tools/commit/f53aa84f1b350045b8342e1b4493bc3aa80c0a8c
Merge pull request #119 from andreadelrio/breaklines

Bug 1284617 - new live log viewer doesn't break lines as well as the old one
Finalized in https://github.com/taskcluster/taskcluster-tools/pull/235
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: Tools → UI and Tools
You need to log in before you can comment on or make changes to this bug.