Move connecting.png and connecting@2x.png to shared/

RESOLVED FIXED in Firefox 50

Status

()

defect
P4
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: seban, Mentored)

Tracking

Trunk
Firefox 50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

connecting.png and connecting@2x.png are the same across platforms. Identical copies exist in browser/themes/linux/tabbrowser/, browser/themes/osx/tabbrowser/ and browser/themes/windows/tabbrowser/.

We should put these two files in browser/themes/shared/tabbrowser/ instead. The windows copies can just be moved there using hg move and the other copies can be removed. browser/themes/*/jar.mn will also need to be updated.
Priority: -- → P3
Priority: P3 → P4
Assignee: nobody → sebastinssanty
Hi Dao,

Made the changes as you have mentioned. Can you please review my patch?
Attachment #8769115 - Flags: review?(dao+bmo)
Comment on attachment 8769115 [details] [diff] [review]
bug1284632_shareconnectingimgs.diff

>--- a/browser/themes/shared/jar.inc.mn
>+++ b/browser/themes/shared/jar.inc.mn
>@@ -100,16 +100,18 @@
>   skin/classic/browser/social/chat-icons.svg                   (../shared/social/chat-icons.svg)
>   skin/classic/browser/social/gear_default.png                 (../shared/social/gear_default.png)
>   skin/classic/browser/social/gear_clicked.png                 (../shared/social/gear_clicked.png)
>   skin/classic/browser/tabbrowser/crashed.svg                  (../shared/tabbrowser/crashed.svg)
>   skin/classic/browser/tabbrowser/pendingpaint.png             (../shared/tabbrowser/pendingpaint.png)
> * skin/classic/browser/tabbrowser/tab-audio.svg                (../shared/tabbrowser/tab-audio.svg)
>   skin/classic/browser/tabbrowser/tab-audio-small.svg          (../shared/tabbrowser/tab-audio-small.svg)
>   skin/classic/browser/tabbrowser/tab-overflow-indicator.png   (../shared/tabbrowser/tab-overflow-indicator.png)
>+  skin/classic/browser/tabbrowser/connecting.png               (../shared/tabbrowser/connecting.png)
>+  skin/classic/browser/tabbrowser/connecting@2x.png            (../shared/tabbrowser/connecting@2x.png)

Looks good, but please keep the alphabetic order, i.e. connecting.png and connecting@2x.png should be listed before crashed.svg.
Attachment #8769115 - Flags: review?(dao+bmo) → review+
Thanks Dao for the review. Made the changes.
Attachment #8769115 - Attachment is obsolete: true
Attachment #8769155 - Flags: review?(dao+bmo)
Comment on attachment 8769155 [details] [diff] [review]
bug1284632_shareconnectingimgs.diff

Thanks!
Attachment #8769155 - Flags: review?(dao+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/a30b1295e596
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in before you can comment on or make changes to this bug.