128464 - Type changes in headers could cause problems

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Mike Kaply [:mkaply]]

We have found a case where the structures in the old header (npapi.h) did not 
match the new header (nsplugindefs.h)

I'm not sure why these changes didn't cause problems with existing plugin 
printing.

My only guess is that plugin vendors caught the problem and worked around it.

Here is what I found:

NPBool (unsigned char) changed to PRBool (int)

in npapi.h (4.x code)

typedef unsigned char   NPBool; 
. 
. 
. 
typedef struct _NPFullPrint 
{ 
  NPBool pluginPrinted;/* Set TRUE if plugin handled fullscreen printing */ 
  NPBool printOne;       /* TRUE if plugin should print one copy to default 
printer */ 
  void* platformPrint; /* Platform-specific printing info */ 
} NPFullPrint; 

in nsplugindefs.h/nsplugindefs.idl, I see the following code: 

struct nsPluginFullPrint { 
    PRBool      pluginPrinted;  /* Set TRUE if plugin handled fullscreen */ 
                                /*  printing                             */ 
    PRBool      printOne;       /* TRUE if plugin should print one copy  */ 
                                /*  to default printer                   */ 
    void*       platformPrint;  /* Platform-specific printing info */ 
}; 

with PRBool defined as an int in prtypes.h

Note that at this point, the main problem we found with OS/2 plugin printing was 
that the pragma pack(1) for our structures was before an include of <os2.h> and 
<os2.h> undid the pragma pack(1). That was the first problem we found. We're 
continuing to look to see what else is causing problems, and this caught our 
eye.

Comment 1

[rubydoo123]

this is a fairly major issue, setting this to be addressed in the next milestone

Comment 2

[Mike Kaply [:mkaply]]

BTW, this only applies to fullscreen plugins - I've no idea why it hasn't caused
headaches already.

Comment 3

[rubydoo123]

adding nsbeta1+

Comment 4

[av (gone)]

Should we just switch from |nsPluginPrint| to |NPPrint| everywhere in our code?
How many plugins may have used nsplugindefs.h already? Java and Real -- none of
those two are normally full-page. What other approach can we try?

Comment 5

[rubydoo123]

moving to 1.3 beta, we need to work through a resolution on this one.

Comment 6

[Peter Lubczynski]

--->taking av's nsbeta1+ bugs

Comment 7

[Mike Kaply [:mkaply]]

I guess we didn't need to work through a resolution after all. This hasn't come up in 8 years of plugins.