If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

DXR uses ES6's "shorthand property names", which isn't supported on safari, IE, ancient firefox versions (<33)

RESOLVED FIXED

Status

Webtools
DXR
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: glob, Assigned: erik)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: js)

(Reporter)

Description

a year ago
DXR uses ES6's "shorthand property names", which isn't universally supported.

https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Operators/Object_initializer#Browser_compatibility

$ jshint dxr/static_unhashed/js/dxr.js
dxr/static_unhashed/js/dxr.js: line 286, col 53, 'object short notation' is available in ES6 (use esnext option) or Mozilla JS extensions (use moz).

> queryString = (dxr.linesUrl + '?' +
>                $.param({path, start: line + c.start, end: line + c.end}));

should be {path: path, start: ..}
(Assignee)

Comment 1

a year ago
PR: https://github.com/mozilla/dxr/pull/590
Assignee: nobody → erik

Comment 2

a year ago
Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/08ce2e9c3f1e15846d4124ad876aff3198513e52
Fix jshint errors. Fixes bug 1284767. (#590)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.