128478 - ViewManager: KeyEvents shouldn't use coordinate-based event dispatching

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P2)

Description

[kinmoz]

This bug was filed to track the removal of this patch:

    http://bugzilla.mozilla.org/attachment.cgi?id=71719&action=view

which landed as a fix for bug 127368, and the replacement with the proposed
mozilla1.0 patch, also in bug 127368:

    http://bugzilla.mozilla.org/attachment.cgi?id=71778&action=view

Right now KeyEvents are being run through the ViewManager::HandleEvent() code
that dispatches based the coordinates in the event. This is how it was done
prior to [e-mail]'s ViewManager tree landing.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We should actually look at all the event types and decide which ones really need
coordinate based dispatch. In theory it should only be needed for the mouse events.

Comment 2

[kinmoz]

Attachment: Test Case (KeyEvents don't reach textarea when div is scrolled)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Proposed fix

Straightforward patch. Seems to work OK.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Let's try to get this into 1.0.

Comment 5

[Kevin McCluskey (gone)]

Comment on attachment 74687 [details] [diff] [review]
Proposed fix

r=[e-mail]

Comment 6

[kinmoz]

Comment on attachment 74687 [details] [diff] [review]
Proposed fix

sr=[e-mail]

Let's get this in ASAP so we can shake out any wierdness, which I *don't*
anticipate, before mozilla1.0.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 74687 [details] [diff] [review]
Proposed fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fix checked in