Closed Bug 1284786 Opened 7 years ago Closed 7 years ago

ARM64: Build errors with --enable-simulator=arm64

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: sk.alvin.x, Unassigned)

Details

Attachments

(1 file)

Fix build errors with --enable-simulator=arm64
395 bytes, patch
bbouvier
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36

Steps to reproduce:

configure with --enable-simulator=arm64 and make


Actual results:

jit/arm64/Assembler-arm64.cpp:628: error: undefined reference to 'js::gc::StoreBuffer::putWholeCell(js::gc::Cell*)

        Attachment #8768305 -
        Flags: review?(sstangl)

    
    

    
  
Comment on attachment 8768305 [details] [diff] [review]
Fix build errors with --enable-simulator=arm64

Review of attachment 8768305 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

        Attachment #8768305 -
        Flags: review?(sstangl) → review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: checkin-needed

    
  

        Attachment #8768305 -
        Flags: checkin?(kvijayan)

        Attachment #8768305 -
        Flags: checkin?(kvijayan)

    
    

    
  
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d60e3945663
Fix build errors with --enable-simulator=arm64. r=bbouvier
Keywords: checkin-needed

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c598237110de
Fix arm64 simulator build failures. r=bbouvier

    
    

    
  
Backout by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd5b68e3f43f
Backed out changeset 9d60e3945663 for spidermonkey style violations on a CLOSED TREE.

    
    

    
  
Oops, sorry about the style issue; next time we'll do a try build as properly required.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c598237110de
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox50:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

          You need to log in
          before you can comment on or make changes to this bug.