1284830 - Tab sound indicator flickers while on www.zurichopenair.ch

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Ada [:adalucinet]]

[Affected versions]:
- latest Aurora 49.0a2 e10s on/off
- latest Nightly 50.0a1 e10s on/off

[Affected platforms]:
- Windows 10 64-bit
- Windows 7 32-bit

[Steps to reproduce]:
1. Launch Firefox
2. Navigate to http://www.zurichopenair.ch

[Expected result]: Tab sound indicator is properly displayed.

[Actual result]: Tab sound indicator flashes.

[Regression range]:
- Last good Nightly → 2016-05-05 
- First bad Nightly → 2016-05-06 
- Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0177462aac74605f426ab9c92e39bb467b7ce2d1&tochange=ffce4cb69e30721c3d41a07c2ea2258b09c6d9ea 

[Additional notes]:
- Screen recording → https://goo.gl/Tqw8DL 
- Not reproducible under Mac OS X 10.11.1 nor Ubuntu 16.04 64-bit

Comment 1

[:Gijs (he/him)]

Looks like a regression from bug 1235612. Alastor, can you investigate?

Comment 2

[Alastor Wu [:alwu]]

The audio indicator would be showed when the value is non-zero and be hided when the value of audio sample is zero.

In this case, this video has very very weak audio signal, the value of the audio sample is almost near zero. When playing the sample which value is near zero, the indicator would be hided.

I guess that the website want to eliminate its audio but doesn't do it completely.

--

One solution is to filter out all value closing zero, but it's hard to define the correct threshold. The actual volume is depending on the hardware amplifier, so in theory we can hear all audio sample if we use the super power amplifier.

Another solution is to implement the delay for hiding the audio indicator. It would be done in bug 1232357. I prefer to use this solution.

Comment 3

[Alastor Wu [:alwu]]

free it, it would be fixed after finishing bug 1232357.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Setting fix-optional to get this off active triage lists. Active bug is bug 1232357.

Comment 5

[Alexandru Simonca [:asimonca], Release Desktop QA]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0

Hi, 
I've reproduced this bug while testing today's Beta 49.0b3 (id: 20160811031722).

[Affected platforms]:
- Windows 10 64-bit
- Windows 7 32-bit
- Ubuntu 12.04 32-bit

[Steps to reproduce]:
1. Launch Firefox
2. Navigate to http://www.stephaniequinn.com/Music/Mozart%20-%20Presto.mp3

[Expected result]: Tab sound indicator is properly displayed.

[Actual result]: Tab sound indicator flashes when there is silence in the audio clip (e.g. at the start & at the end of the clip)

Comment 7

[Paul Silaghi, QA [:pauly]]

Fixed by bug 1232357.

Comment 8

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 52.0a2 (2016-11-28) Win 7

Comment 9

[Gerry Chang [:gchang]]

Too late for 51 and we don't plan to have dot release for 51. Mark 51 won't fix.