Closed Bug 1284839 Opened 3 years ago Closed 3 years ago

Reps: Handle spaces between title and rep

Categories

(DevTools :: Shared Components, enhancement, P1)

enhancement

Tracking

(firefox50 affected, firefox51 fixed)

RESOLVED FIXED
Firefox 51
Iteration:
51.2 - Aug 29
Tracking Status
firefox50 --- affected
firefox51 --- fixed

People

(Reporter: linclark, Assigned: Honza)

References

(Blocks 1 open bug)

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

Some reps do this, but we should make it uniform. There should always be a space after the title if it's followed by something.
Blocks: 1283847
Whiteboard: [devtools-html] [triage]
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
I would like to work on this bug. It would be great if you help me where to start with?
We have a few more bugs that need to land before this one is ready. I added the issue tracking those as a blocker to this one.
Depends on: 1257552
As the blocker for this one is resolved Can I start working on this bug ?
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Iteration: --- → 51.2 - Aug 29
Priority: P2 → P1
Comment on attachment 8785985 [details] [diff] [review]
bug1284839.patch

Review of attachment 8785985 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, and it's green on try, so I think it's good to go.
Attachment #8785985 - Flags: review?(lclark) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/71d195130d77
Reps: Handle spaces between title and rep. r=linclark
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/71d195130d77
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.