Closed Bug 1284854 Opened 6 years ago Closed 5 years ago

Reps: make sure function title shows up correctly

Categories

(DevTools :: Shared Components, enhancement, P3)

enhancement

Tracking

(firefox50 affected)

RESOLVED WORKSFORME
Tracking Status
firefox50 --- affected

People

(Reporter: linclark, Unassigned)

References

Details

(Whiteboard: [reserve-html])

Attachments

(1 file, 1 obsolete file)

When the object link patch lands, if an objectLink prop is provided, then an anonymous function will show up as functionfunction().
Blocks: 1283847
Whiteboard: [devtools-html] [triage]
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
could you provide the dependent bug(object link patch) and the expect result (compared to functionfunction())?
Flags: needinfo?(lclark)
I've added the dependent bug. Once that lands, the output should be changed so that it displays function() or function ()... but the word function should be wrapped in the object link.
Depends on: 1283123
Flags: needinfo?(lclark)
Can I work on this bug ? Is it assigned to someone ?
It is not assigned to anyone so feel free to take it.
how do I test my changes whether they are working or not ?
I dont have any test cases to test it . Can you provide me with steps to reproduce the bug
Attachment #8772827 - Flags: review?(lclark)
Assignee: nobody → hems.india1997
Status: NEW → ASSIGNED
Iteration: --- → 50.4 - Aug 1
Priority: P2 → P1
There are two cases that you have to test. One is where no object link is provided. This is the case in the DOM Panel. The other case is where an object link is provided. This is the case in the web console. To test it in the web console, you have to be using the Nightly version of Firefox and turn on the devtools.webconsole.new-frontend-enabled flag.
Comment on attachment 8772827 [details] [diff] [review]
Bug1284854 - Reps: make sure function title shows up correctly r=linclark

Review of attachment 8772827 [details] [diff] [review]:
-----------------------------------------------------------------

The patch attached won't cover both those cases, so I'm clearing the review for now.
Attachment #8772827 - Flags: review?(lclark)
(In reply to Lin Clark [:linclark] from comment #7)
> There are two cases that you have to test. One is where no object link is
> provided. This is the case in the DOM Panel. The other case is where an
> object link is provided. This is the case in the web console. To test it in
> the web console, you have to be using the Nightly version of Firefox and
> turn on the devtools.webconsole.new-frontend-enabled flag.
I tried the Second One and its working.Can you please check the second one? Also, I think one test needs to be updated as well the "test_reps_function.html" one. Any comments on that?
Also I tried declaring a function like this
> x = new Function(); 
then it shows up as function anonymous() in console log and x() in DOM. Is there any other way to declare Anonymous function so as to check it in the DOM panel? 
I tried this thing 
> (function (msg){alert(msg)}); 
in console log and it showed a link as function (). However it did not show anything in DOM panel even if I refreshed it.
Also it is not clear what does DOM Panel show (or should show) when an anonymous function is called?
Flags: needinfo?(lclark)
I don't know of a good example in the DOM Panel. This might be too tricky to tackle right now.
Flags: needinfo?(lclark)
This Patch covers the case II ( when an object link is provided. ) of the bug. I tested it and it worked. Please check If I am wrong somewhere.
Attachment #8772827 - Attachment is obsolete: true
Attachment #8775012 - Flags: review?(lclark)
Comment on attachment 8775012 [details] [diff] [review]
Bug1284854 - Reps: make sure function title shows up correctly r=linclark

Review of attachment 8775012 [details] [diff] [review]:
-----------------------------------------------------------------

This patch would break a different case. As I mentioned in the comment above, I think this one might be too hard to explain. However, there is another good issue to work on, https://bugzilla.mozilla.org/show_bug.cgi?id=1284843. You can see the steps that need to be done in the last comment on that issue.
Attachment #8775012 - Flags: review?(lclark) → review-
Iteration: 50.4 - Aug 1 → 51.1 - Aug 15
Iteration: 51.1 - Aug 15 → 51.2 - Aug 29
Hello Hemanth, following up if you are still interested in completing this bug or can it be reassigned?
Flags: needinfo?(hems.india1997)
(In reply to Marco Mucci [:MarcoM] from comment #15)
> Hello Hemanth, following up if you are still interested in completing this
> bug or can it be reassigned?

I am interested in it. But as Lin clark mentioned my patch would break a different case I am waiting for the dependant bug (if any) to be resolved. If its ready to be worked on, I will definitely love to work on this one.
Hi Lin, following up if this bug can proceed given the dependency (bug 1283123) has been completed or is there another dependency that is required?
Flags: needinfo?(hems.india1997) → needinfo?(lclark)
There are a few things in the air right now that will impact this, so I think we should put it on the back burner for now.
Assignee: hems.india1997 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(lclark)
Iteration: 51.2 - Aug 29 → ---
Priority: P1 → P3
Whiteboard: [devtools-html] → [reserve-html]
Entering `() => {}` of `function(){}` in the jsterm does output "function ()"
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.