1284940 - Do we have more checkerboarding since 48?

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P2)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Beta checkerboarding log

Randomly on this page, but there are multiple examples, including bugzilla:

https://teslamotorsclub.com/tmc/threads/supercharger-bay-city-mi.69400/

Comparing Beta 48 (with E10S/APZ on) and Aurora 49 (the same)

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Aurora checkerboarding log

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

This is retina Mac; will check if it happens on other platforms or hardware.  Tagging as regression to make sure we keep looking at this.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

The paint times in the aurora log are 420ms and 730ms which are quite long. The longest paint time in the beta one is 296ms. But we don't know why the paint time is so long. Based on when this started appearing and that only people on retina mac devices have reported it, I suspect it might be the 100 tile limit that I put in bug 1262807 is too small.

Try build at https://treeherder.mozilla.org/#/jobs?repo=try&revision=c082092bcf07 makes that limit preffable, so we can increase it and see if it helps. (The build also makes it 1000 by default).

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Much better with the patch.  The mystery now is, as I understand it, that we're not sure why things are better in Beta than in Aurora.

Are the paint times mentioned above that much larger for the same size of regions getting painted?  As in, painting slowed down?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

It could be that painting slowed down, or it could be that we're invalidating more areas. Comparing what's happening with paintflashing enabled would probably allow distinguishing between the two scenarios.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

P2 because it seems to only affect retina mac users so far.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1284940 - Increase the max number of tiles in a TiledRegion.

Review commit: https://reviewboard.mozilla.org/r/63492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63492/

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8769758 [details]
Bug 1284940 - Increase the max number of tiles in a TiledRegion.

https://reviewboard.mozilla.org/r/63492/#review60354

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76dbce2010b4
Increase the max number of tiles in a TiledRegion. r=mstange

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76dbce2010b4

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8769758 [details]
Bug 1284940 - Increase the max number of tiles in a TiledRegion.

Approval Request Comment
[Feature/regressing bug #]: bug 1262807
[User impact if declined]: more checkerboarding in some configurations (so far only seen on a retina display on OS X)
[Describe test coverage new/current, TreeHerder]: not much automated test coverage; users who reported the increased checkerboarding say this helps
[Risks and why]: very low risk, just increasing a compile-time constant
[String/UUID change made/needed]: none

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Marking 48 as fix-optional because even though this extra checkerboarding wasn't seen on 48, the regressing patch is on 48 and so it's probably better to uplift this fix there as well.

Comment 13

[Gerry Chang [:gchang]]

Given this issue was not seen in 48 and it's late beta, mark won't fix in 48.

Comment 14

[Gerry Chang [:gchang]]

Comment on attachment 8769758 [details]
Bug 1284940 - Increase the max number of tiles in a TiledRegion.

Per comment #13, won't fix in 48.

Comment 15

[Markus Stange [:mstange]]

This only started happening on Beta 19 days ago, when bug 1262807 got uplifted to Beta. I think we should still uplift this. I'd hate to ship APZ in 48 with lots of checkerboarding on retina Macs.

Comment 16

[Gerry Chang [:gchang]]

Hi Milan,
Per comment #4, may I know if you have any feedback if this needs to be uplift to 48 beta?

Comment 17

[Kartikaya Gupta (email:[e-mail])]

^

Comment 18

[Milan Sreckovic [:milan] (needinfo for best results)]

Yes, I we would really want it on Beta.  Can't make the approval-mozilla-beta a ?, otherwise I would :)

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Gerry, any chance you'll reconsider this for 48? ^

Comment 20

[Gerry Chang [:gchang]]

Hi Kartikaya,
Let's take it in beta. Can you help to create the uplift request again? Thanks.

Comment 21

[Kartikaya Gupta (email:[e-mail])]

I can't change the beta approval flag to any other value from the minus. It probably requires extra bugzilla permissions that I don't have. Can you just flip it back to a + directly? I don't have much new to add from the last uplift request.

Comment 22

[Gerry Chang [:gchang]]

Comment on attachment 8769758 [details]
Bug 1284940 - Increase the max number of tiles in a TiledRegion.

This patch fixes a checkboarding issue. Take it in 48 beta 8 and aurora.

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6bc76a1b5dbb

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b76b34484027