Closed Bug 128496 Opened 23 years ago Closed 20 years ago

Manager: Scroll bar (Stored Cookies & Cookie Sites) is partially covered in Classic skin

Categories

(Core :: Networking: Cookies, defect, P4)

defect

Tracking

()

VERIFIED WORKSFORME
mozilla1.7beta

People

(Reporter: moied, Assigned: mconnor)

References

Details

Attachments

(3 files)

Scroll bar in Stored cookies under “cookie manager” is not align at the end of
the list, and when you scroll down with after 6 items the scroll bar disappears,
user can only navigate using keyboard arrow keys to scroll down 

Reproducible: Always
Steps to Reproduce:
1.Click Edit – Preferences 
2.Try to go back to privacy and security 
3.Click on Cookies
4.Click on Manage stored cookies
5.Stored cookies tab under Cookie manager.
6.Scroll bar is not aligned in this tab.

Actual Results:  Scroll bar is not aligned in this tab

Screen shot fallows …
I can't reproduce this on my winNT machine.  Is this a problem on windowsXP 
only?
Summary: Scroll bar in Stored cookies malfunction → Scroll bar in Stored cookies malfunction
This bug is a dupe of bug 125774, but I'm not sure which if either should be
kept, so I'm just commenting in both.  Also see bug 127126 comment 1 which
suggests all of this could have gone away in latest builds.
sorry for the double comment.  also see bug 130211.
this belongs in cookies, not prefs. :)
Assignee: sgehani → morse
Component: Preferences → Cookies
QA Contact: sairuh → tever
*** Bug 125774 has been marked as a duplicate of this bug. ***
so far I have only seen this on moeid's win XP box.  Works for me on mac osX and
linux rh6.   
Keywords: pp
ok, I just checked the lab (win XP) machine I tested a few weeks ago in the
duped bug.   Everything is fine as long as you are using modern skin, but when
you switch to classic skin the scroll bar problems appear.  Still only on win xp.
OK, this is a skin problem.  Reassigning.
Assignee: morse → hewitt
Component: Cookies → Themes
QA Contact: tever → pmac
*** Bug 127126 has been marked as a duplicate of this bug. ***
some reporters are seeing this on mac osX too, changing OS to all

also nominating nsbeta1, loss of functionality, switching skins would be a
workaround but I don't think that is too apparent
Severity: normal → major
Component: Themes → Cookies
Keywords: ppnsbeta1
OS: Windows XP → All
QA Contact: pmac → tever
*** Bug 130765 has been marked as a duplicate of this bug. ***
What loss of functionality is there here?  
> What loss of functionality is there here?  

Although not specified in this bug report, in the dup bug 127126 it says that 
the scroll bar is not only displaced but that it also doesn't work.  Of course I 
can't confirm any of this because I can't reproduce it.
qawanted: Can you scroll this list using XP?
Keywords: qawanted
Whiteboard: [need info]
You can't scroll down using the scroll bar but after selecting a name value pair 
we can scroll down using down arrow key. removing KW:qawanted 
Keywords: qawanted
What about PgUp,PgDn?
Keywords: qawanted
nsbeta1- per Nav triage team, can still scroll with keyboard and with scrollbar
after resizing window. low impact
Keywords: nsbeta1nsbeta1-
Whiteboard: [need info]
Target Milestone: --- → mozilla1.2alpha
PgUp,PgDn also works
I see that recent builds have changed the "manage cookies" window from a sheet
to a seperate window. This does indeed fix 99% of the problem. Should it really
be a sheet though? Not sure.

If the plan is to leave this as a seperate window, the only thing left to do is
increase the default size of this window... 
*** Bug 138848 has been marked as a duplicate of this bug. ***
Shows the scrollbar partly obscured
I played with my cookieview.xul and changed width=30em to width=32em.

This gets the scrollbar to appear properly when you open the window. However, as
soon as you resize the window and make it smaller, the problem reappears. 

The issue is that the scrollbar seems to be floating above the bounding window
frame yet the frame still gets focus, thus the non functioning scrollbars. You
can see this by resizing so the scrollbar is only partly obscured by the window
around it. Then, the part of the scrollbar to the right cannot be clicked, but
the part to the left (INDICATED IN RED in my previous attachment) can be clicked. 



BTW - changing the width to 32em also makes the message "view and remove cookies
that are stored on your computer."  appear in its entirety, whereas before it is
truncated to "view and remove cookies that are stored on your comp"
*** Bug 138991 has been marked as a duplicate of this bug. ***
Further refinement to the problem. This issue is related to the choice of themes
on XP.

If you switch your theme to Windows Classic then this issue is not present.
Switch back to XP Theme and the scrollbar is wrong again.
As per my comment in #23, could we possibly have this interim fix added to the
1.0 branch code? 

The bug it ugly and my fix takes the visibilty aware enough to make the 1 min
source code hack worth it (I think).
I can't reproduce this in RC3 in winxp.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1) Gecko/20020826

This is only happening if Windows XP visual styles option is enabled, but it’s
not specific to the Cookie manager dialog. It seems that similar scroll bar
glitches is also present elsewhere.

While XP styles enabled, view testcase of Bug #164870 and see if the bottom
arrow of the vertical scrollbar is working or even visible. 
Seen on OpenVMS (build like UNIX) too.
Similiar bug happends with the Windows Classic mode, see bug 186898.
Most reports, except comments #26 and #29 say this is classic only.

I've cleaned up the duplicates. Using Mozilla 1.3f, this happened once to me in
Mach-O, Linux and Windows.

Going into Modern theme, then back to classic, seems to make the problem go
away, so there is some aspect of the default values of Classic that cause this.

This would also explain why we have so few complaints about such an essential UI
element being broken.

I also see all the annoying behaviors everyone else described, like the
scrollbar not working unless it is 100% visible, partially drawn scroll bars,
and incorrect minimum size for the manager. Since these might be separate bugs,
I'll try to isolate them.
Assignee: hewitt → darin
Hardware: PC → All
Summary: Scroll bar in Stored cookies malfunction → Manager: Scroll bar (Stored Cookies & Cookie Sites) is partially covered in Classic skin
*** Bug 178353 has been marked as a duplicate of this bug. ***
*** Bug 186898 has been marked as a duplicate of this bug. ***
*** Bug 184875 has been marked as a duplicate of this bug. ***
Those screenshots show how this bug has changed after 1.2.1 (and this way has
caused more bug reports than before):
Earlier (1.0.x branch as example) things just disappeared at the right. That's
not good, but unfortunately that happens at various places in Mozilla, so it's
nothing special.
After 1.2.1 some things began tokeep distance from the right border to be
always visible (which is good): the buttons at the bottom and the tabbing pane.
Unfortunately the contents of that pane (content area with scrollbar, groupbox)
have a minimum size (obviously caused by the text at the top - it's the same
width) and now print over the right border of their containing pane when that
one gets smaller than their minimum size.

But there is no change in CookieViewer.xul during the time in question, so
another fix must have caused that change of behaviour.

Maybe letting the text wrap and/or giving the dialog a minimum width could fix
it.

Please also read bug 186898 comment #5 where I show that other dialogs (as the
Image Manager) are also affected!
(Time to change the Target Milestone from v1.2a to !?!)
QA apparently no longer wanted. 
Flags: blocking1.4a?
Keywords: qawanted
Flags: blocking1.4a? → blocking1.4a-
[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4a) Gecko/20030401]

Bug still there. (with v1.3 profile, at least)

Even the 'Close' and 'Help' button at the bottom right of the "window" can be
affected.

NB: This bug seems to have changed a little ("better") between v1.3 and v1.4a.
Re comment #39:
Yes, it's a little better now in current builds.
To be more exact: it looks and behaves again as in my "before" screenshot in
comment #36: you can make the dialog smaller than the content, but at least
nothing is completely distorted (neither with horizontal nor vertical resizing).
Actually what's left of the problem seems to be a duplicate of bug 64470.
At least on Win2k; maybe XP luna appearance is different (comment #29 seems to
suggest that) and there is more than just content disappearing...
Re comment 40: Agreed.

Re comment 41:

Bug 64470 seems (closely) related to the current (multi-platform) one: I don't
know enough to say more.

If there is (also) a WXP specific issue, I suggest to file a separate bug about it.
Flags: blocking1.4b?
I cannot reproduce this anymore with build 2003042112, Win 2000
Flags: blocking1.4b? → blocking1.4b-
-> me, YACMB

I can resize the window to get this effect.  But does it happen on a new
profile, or only if you have a persisted size in the existing profile?

If it doesn't happen on a clean profile, this should be WORKSFORME
Assignee: darin → mconnor
minor, window can be resized in this case.

If no one can state this can still be replicated and provide steps to reproduce,
I'll mark this WORKSFORME in two weeks.
Severity: major → minor
Priority: -- → P4
Target Milestone: mozilla1.2alpha → mozilla1.7beta
did I say weeks? I meant months! :)
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME
V/wfm.
I tested Mozilla 1.8a4, new profile, in classic mode.

I also spent several months working on both skins for Netscape 7.2 (mozilla
1.7.x), and did not notice this during my time on that project.
Status: RESOLVED → VERIFIED
QA Contact: tever → benc
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: