Allow 0-RTT in selfserv

RESOLVED FIXED in 3.26

Status

NSS
Tools
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: fkiefer, Assigned: fkiefer)

Tracking

trunk
3.26

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8768484 [details] [diff] [review]
zero-rtt-selfserv.patch
Attachment #8768484 - Flags: review?(ekr)

Comment 1

2 years ago
Comment on attachment 8768484 [details] [diff] [review]
zero-rtt-selfserv.patch

Review of attachment 8768484 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: cmd/selfserv/selfserv.c
@@ +1992,5 @@
> +        rv = SSL_OptionSet(model_sock, SSL_ENABLE_0RTT_DATA, PR_TRUE);
> +        if (rv != SECSuccess) {
> +            errExit("error enabling 0RTT ");
> +        }
> +    }

Maybe generate an error if you set 0RTT w/o enabling 1.3?
Attachment #8768484 - Flags: review?(ekr) → review+
https://hg.mozilla.org/projects/nss/rev/2aca46707a66
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
backed out due to bustage
https://hg.mozilla.org/projects/nss/rev/ee489d2d7398
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/projects/nss/rev/f57a4ba05b4e
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.