Closed
Bug 1284977
Opened 8 years ago
Closed 8 years ago
Use an aligned poison value for SetToCrashOnTouch
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
1.97 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
SetToCrashOnTouch uses a reasonable literary reference of 0x42 for its poison value. Unfortunately this "pointer" does not have proper alignment for all of the types we want to use with it. I cannot see what this fact would allow a compiler to assume that would result in incorrect code, but I'm not particularly smart C++ compiler. Let's instead err on the side of safety.
Attachment #8768504 -
Flags: review?(jdemooij)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → terrence
Assignee | ||
Comment 1•8 years ago
|
||
Oh, hey, we actually assert on the poisoned value. This should work better.
Attachment #8768504 -
Attachment is obsolete: true
Attachment #8768504 -
Flags: review?(jdemooij)
Attachment #8768505 -
Flags: review?(jdemooij)
Assignee | ||
Comment 2•8 years ago
|
||
And we create ad-hoc poisoned values using a bare constant 0x42. I think this is the only one.
Attachment #8768505 -
Attachment is obsolete: true
Attachment #8768505 -
Flags: review?(jdemooij)
Attachment #8768563 -
Flags: review?(jdemooij)
Assignee | ||
Updated•8 years ago
|
Component: JavaScript: GC → JavaScript Engine
Updated•8 years ago
|
Attachment #8768563 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/80ad0f56e596951e775942ce04db87509d8608b1 Bug 1284977 - Use a properly aligned poison value; r=jandem
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/80ad0f56e596
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•