Closed Bug 1284977 Opened 7 years ago Closed 7 years ago
Use an aligned poison value for Set
To Crash On Touch
SetToCrashOnTouch uses a reasonable literary reference of 0x42 for its poison value. Unfortunately this "pointer" does not have proper alignment for all of the types we want to use with it. I cannot see what this fact would allow a compiler to assume that would result in incorrect code, but I'm not particularly smart C++ compiler. Let's instead err on the side of safety.
Oh, hey, we actually assert on the poisoned value. This should work better.
And we create ad-hoc poisoned values using a bare constant 0x42. I think this is the only one.
Attachment #8768563 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/80ad0f56e596951e775942ce04db87509d8608b1 Bug 1284977 - Use a properly aligned poison value; r=jandem
You need to log in before you can comment on or make changes to this bug.