Closed Bug 1285021 Opened 6 years ago Closed 6 years ago
URL tabs don't work
58 bytes, text/x-review-board-request
The discussion in the meeting that lead to bug 1284669 made me realize that we try to do this, but it won't work. Very easy to repro, try https://jsfiddle.net/Lk506vw9/ Nothing bad happens, it's just a tab that never loads. We either shouldn't try to sync it at all, since it's specific to the browser it comes from, or we should convert it to a data url and sync that instead.
IIUC, the problem is that the blob: URL syncs correctly, it's just that it has no content when opened, right? If so, the simple answer is probably to just add a new pattern in https://dxr.mozilla.org/mozilla-central/source/services/sync/services-sync.js#33
Yes, exactly, and I can confirm making that fix solves the problem.
Review commit: https://reviewboard.mozilla.org/r/62884/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62884/
Attachment #8768861 - Flags: review?(markh)
Comment on attachment 8768861 [details] Bug 1285021 - Exclude urls starting with blob: from tab syncing https://reviewboard.mozilla.org/r/62884/#review59878
Attachment #8768861 - Flags: review?(markh) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/fx-team/rev/74dd49dcf6c9 Exclude urls starting with blob: from tab syncing. r=markh
You need to log in before you can comment on or make changes to this bug.