1285021 - Synced objectURL tabs don't work

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

The discussion in the meeting that lead to bug 1284669 made me realize that we try to do this, but it won't work. Very easy to repro, try https://jsfiddle.net/Lk506vw9/

Nothing bad happens, it's just a tab that never loads. We either shouldn't try to sync it at all, since it's specific to the browser it comes from, or we should convert it to a data url and sync that instead.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

IIUC, the problem is that the blob: URL syncs correctly, it's just that it has no content when opened, right? If so, the simple answer is probably to just add a new pattern in https://dxr.mozilla.org/mozilla-central/source/services/sync/services-sync.js#33

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Yes, exactly, and I can confirm making that fix solves the problem.

Comment 3

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1285021 - Exclude urls starting with blob: from tab syncing

Review commit: https://reviewboard.mozilla.org/r/62884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62884/

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8768861 [details]
Bug 1285021 - Exclude urls starting with blob: from tab syncing

https://reviewboard.mozilla.org/r/62884/#review59878

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/74dd49dcf6c9
Exclude urls starting with blob: from tab syncing. r=markh

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/74dd49dcf6c9