Closed Bug 1285053 Opened 3 years ago Closed 3 years ago

New console frontend: use variables view link for object inspection

Categories

(DevTools :: Console, enhancement)

enhancement
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: linclark, Assigned: linclark)

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → lclark
Status: NEW → ASSIGNED
Comment on attachment 8770254 [details]
Bug 1285053 - New console frontend: use variables view link for object inspection.

Carrying over review from GitHub
Attachment #8770254 - Flags: review?(chevobbe.nicolas) → review+
Keywords: checkin-needed
Comment on attachment 8770254 [details]
Bug 1285053 - New console frontend: use variables view link for object inspection.

https://reviewboard.mozilla.org/r/63750/#review61088
Attachment #8770254 - Flags: review+
Pushed by lclark@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb5d09eec5ee
New console frontend: use variables view link for object inspection. r=bgrins
Keywords: checkin-needed
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/112cc226ba7c
Backed out changeset bb5d09eec5ee for failures in test_evaluation-result.html
Sorry had to back this out in https://hg.mozilla.org/integration/autoland/rev/112cc226ba7c because it broke test_evaluation-result.html
Flags: needinfo?(lclark)
Attachment #8770254 - Attachment is obsolete: true
Flags: needinfo?(lclark)
Attached patch Bug1285053.patchSplinter Review
Ah, thanks for backing it out.

The try string that I used was this:

> try: -b o -p linux,macosx64,win32 -u xpcshell,mochitests -t none 

And it didn't return any related failures for me. Does that try string tigger a run of the test that failed? Or do I need to modify it?

I've attached a patch that fixes the test and carried over the r+
Flags: needinfo?(ihsiao)
Attachment #8770942 - Flags: review+
Hi Lin,

normally that try syntax should have worked. The failures it seems where mostly in m-other tests like here : https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bb5d09eec5ee&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

no idea why the try run didn't catch this - at least the try syntax from you look ok
Flags: needinfo?(ihsiao)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/e0e3108d38d8
New console frontend: use variables view link for object inspection. r=bgrins
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e0e3108d38d8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.