1285053 - New console frontend: use variables view link for object inspection

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Lin Clark [:linclark]]

See https://github.com/devtools-html/gecko-dev/issues/111

Comment 1

[Lin Clark [:linclark]]

Attachment: Bug 1285053 - New console frontend: use variables view link for object inspection.

Review commit: https://reviewboard.mozilla.org/r/63750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63750/

Comment 2

[Lin Clark [:linclark]]

Comment on attachment 8770254 [details]
Bug 1285053 - New console frontend: use variables view link for object inspection.

Carrying over review from GitHub

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8770254 [details]
Bug 1285053 - New console frontend: use variables view link for object inspection.

https://reviewboard.mozilla.org/r/63750/#review61088

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb5d09eec5ee
New console frontend: use variables view link for object inspection. r=bgrins

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/112cc226ba7c
Backed out changeset bb5d09eec5ee for failures in test_evaluation-result.html

Comment 6

[Iris Hsiao [:ihsiao]]

Sorry had to back this out in https://hg.mozilla.org/integration/autoland/rev/112cc226ba7c because it broke test_evaluation-result.html

Comment 7

[Lin Clark [:linclark]]

Attachment: Bug1285053.patch

Ah, thanks for backing it out.

The try string that I used was this:

> try: -b o -p linux,macosx64,win32 -u xpcshell,mochitests -t none 

And it didn't return any related failures for me. Does that try string tigger a run of the test that failed? Or do I need to modify it?

I've attached a patch that fixes the test and carried over the r+

Comment 8

[Carsten Book [:Tomcat]]

Hi Lin,

normally that try syntax should have worked. The failures it seems where mostly in m-other tests like here : https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bb5d09eec5ee&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

no idea why the try run didn't catch this - at least the try syntax from you look ok

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/e0e3108d38d8
New console frontend: use variables view link for object inspection. r=bgrins

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e0e3108d38d8