1285129 - Moving card out from folder cannot make add folder icon appear

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Mike Lien[:mlien]]

[Testing Steps]
1. Home -> Apps -> Pin any app to Home
2. Repeat step 1
3. Home -> Invoke add folder
4. Choose all apps and press OK on Done button (back to home and add folder icon will disappear)
5. Navigate to any card in step 4's folder
6. Press option key -> Move
7. Move card out from folder then press OK key

[Expected result]
Card is moved out from folder and add folder icon will appear

[Actual result]
Add folder icon still disappear

[Build Info]
Environment: 2.6 Nexus Player
gaia:
https://github.com/mozilla-b2g/gaia/commit/ace1cb9e420c432ade14f0829d33ca72c73ecc6c
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/b7f962788a7fa3fc8e49a33a4b4e7799730a3937

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1285129_tv_no_add_folder_button > mozilla-b2g:v2.6

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8768726 [details] [review]
[gaia] luke-chang:1285129_tv_no_add_folder_button > mozilla-b2g:v2.6

Hi Rex,

It's a one-line fix. Let me explain how it works. There are four modes in homescreen: '' (normal), arrange, filter, card-picker. The add-folder button should appear only in the normal mode, so that's why we used "!!this.mode" to determine the status before. However, if card-list-changing event happens during arrange mode, the "checkAddFolderButton" will be called during arrange mode, too, and the button will always be set to hidden. That's the bug.

Actually, we don't really need to care about card-picker mode and arrange mode in "checkAddFolderButton" since the add-folder button will be hid by other css rules. That is to say, we only need to hide the button in filter mode. Fortunately, no card-list-changing events should happen during filter mode. So, that's the fix.

Could you take a look? Thanks.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8768726 [details] [review]
[gaia] luke-chang:1285129_tv_no_add_folder_button > mozilla-b2g:v2.6

Looks good.
Thanks!

Comment 4

[Luke Chang [:lchang] (inactive)]

Rex, Thanks.

landed on v2.6: https://github.com/mozilla-b2g/gaia/commit/41d41687cf23d3a7f0acfa621e263293f78d3db5