128514 - Changing bullet style options for changing entire list or just selected items functions strangely

Status: NEW

(Core :: DOM: Editor, defect, P5)

Description

[michael wendell]

When changing the bullet style does not act the way that I would expect it to.

Steps to reproduce:
1. Launch Composer
2. Create a bulleted list with 5 lines of text
3. Highlight the third list item, right click on it and choose list properties
4. Change the bullet style to "open circle" and have it applied only to the 
selected items
5. Highlight the entire list, right click on it and choose list properties again
6. This time change it to "squares" and apply it to the entire list, and click 
OK

Actual results:
All the bullets change except for the one you changed in step 4.

Expected results: 
I would expect that the list item I had changed earlier would change with the 
rest of the list.
 
Also:
If after step 6, if you try to change one of the other bullet styles by 
highlighting one list item and choosing "Change just selected items", it 
changes the whole list except for the one that you changed earlier in step 4.

This was reproduced on Win XP, Win 98 and Mac OSX all using the 03-01 trunk 
build.

Comment 1

[Joe Francis]

cc'ing Charlie.  This sounds like a dup to me but i cannot find the other bug.  
Do you have it Charlie?

Comment 2

[Charles Manske]

Yes, it's one of the things (#2) listed in bug 115042.
This may be the only part worth trying to fix. I'm not sure how much of a pain it
would be. Basically, when we apply the style to the "Entire list", we are setting
the "type" attribute on the OL, and we are not enumerating all the LI's in the 
selection to remove the "type" from each of them. Is this a pain to do?
BTW, this is all handled in core code: 
nsHTMLEditor::MakeOrChangeList(aListType, entireList, aBulletType).
So when "entireList" is true, maybe do what you would do when false using 
aBulletType = "", ie., clear the type attribute for entire selection first.
Then set the "type" on the list element to whatever requested?

Comment 3

[Joe Francis]

The days of having a half dozen milestones out in front of us to divide bugs 
between seem to be gone, though I dont know why.  Lumping everything together as 
far out as I can.  I'll pull back things that I am working on as I go.

Comment 4

[Joe Francis]

[ushing these out as far as bugzilla will let me.  I'll pull them back as I work
on them.

Comment 5

[Kevin McCluskey (gone)]

nsbeta1-. Joe is overloaded with EDITORBASE+ bugs.

Comment 6

[jrp]

http://pun.org/ has a CSS2 style sheet that selects an image for the bullets for
the lists. On first visit the image only partially loads: what should be a
square is a squat little rectangle. Refresh and it's the square it should have
been! Both the big and little bullets do it.

Comment 7

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=5 years untouched DOM/Storage bugs' priority.

If you have reason to believe this is wrong (especially for the severity), please write a comment and ni :jstutte.