Closed Bug 1285144 Opened 8 years ago Closed 8 years ago

Spatial navigation to top sites and pressing OK key, the blue square won't zoom together

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.6?)

RESOLVED FIXED
blocking-b2g 2.6?

People

(Reporter: mlien, Assigned: danhuang)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

After discussed with UX, we need to make browser behavior consistent. The tab list's tab switch will zoom white square together.

[Testing Steps]
1. Launch Browser app
2. Spatial navigation to any top site item
3. Press OK key

[Expected result]
Blue square will zoom together

[Actual result]
Only page shortcut will zoom

[Build Info]
Environment: 2.6 Nexus Player
gaia:
https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/1f9da1c47090cd29110df577ea1708cf6531c299
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
Comment on attachment 8769555 [details] [review]
[gaia] danhuang1202:v2.6_1285144 > mozilla-b2g:v2.6

Please help review this patch. This patch add css rules for scaling the focus effect when pressing OK button on top-site. Thanks.
Attachment #8769555 - Flags: review?(lchang)
Comment on attachment 8769555 [details] [review]
[gaia] danhuang1202:v2.6_1285144 > mozilla-b2g:v2.6

Looks good! Thanks.
Attachment #8769555 - Flags: review?(lchang) → review+
Thanks for the review.
Merge in v2.6: https://github.com/mozilla-b2g/gaia/commit/94640aa3fbe5003b2bf56f3bce7b47bd34968621
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: