1285253 - JavaScript Warning: "Error in parsing value for ‘text-anchor’. Declaration dropped." {file: "resource://devtools/server/actors/highlighters.css" line: 332 column: 15 source: " text-anchor: left;"}

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Ian Moody [:Kwan] (UTC+0)]

Noticed in a test log:
https://treeherder.mozilla.org/logviewer.html#?job_id=10330926&repo=fx-team#L2686

Cause: https://dxr.mozilla.org/mozilla-central/rev/09221c72fcb03a7c2b4ab27c75304eae3247e3d1/devtools/server/actors/highlighters.css#321

According to https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/text-anchor the value wanted was likely start

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1285253 - Change incorrect "text-anchor: left" to "start".

Also fix a typo in a comment, "Rules" -> "Rulers"

Review commit: https://reviewboard.mozilla.org/r/62844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62844/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8768821 [details]
Bug 1285253 - Change incorrect "text-anchor: left" to "start".

https://reviewboard.mozilla.org/r/62844/#review59786

Looks good thanks for fixing this!

Comment 3

[Ian Moody [:Kwan] (UTC+0)]

Thanks for the review Julian!

No try run as it's a trivial CSS fix that doesn't change any behaviour.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/66a35bd16dbd
Change incorrect "text-anchor: left" to "start". r=jdescottes

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/66a35bd16dbd