Closed Bug 128527 Opened 24 years ago Closed 23 years ago

disabling a radio button doesn't disable the text.

Categories

(Core :: XUL, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: skasinathan, Assigned: hwaara)

Details

Attachments

(2 files)

537 bytes, patch
andreww
: review+
hewitt
: superreview+
jesup
: approval+
Details | Diff | Splinter Review
292 bytes, application/vnd.mozilla.xul+xml
Details
If I set the disabled property on a radio button, it disables only the radiobutton, NOT the text. Checkbox disables bothe the checkbox button and the text.
Attached patch FixSplinter Review
The problem was a improper CSS attribute check in the theme for disabled radios. I checked, and this is a modern-only issue. Can I get some themes reviews?
Attached file Testcase
Testcase for QA purposes.
Comment on attachment 79455 [details] [diff] [review] Fix r=andreww - please check to see if you really need to set "!important" on the rule - it may be that it simply has more weight already due to it's specificity.
Attachment #79455 - Flags: review+
Comment on attachment 79455 [details] [diff] [review] Fix sr=hewitt
Attachment #79455 - Flags: superreview+
->moi
Assignee: hyatt → hwaara
Checked the fix in on the trunk. Let's see if drivers will approve it for the branch too...
Fixed on both branch and trunk.
Status: NEW → RESOLVED
Closed: 23 years ago
Keywords: fixed1.0.0
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: