Closed Bug 1285289 Opened 4 years ago Closed 4 years ago

Install devtools/ test addons as Temporary Addons to prevent signing failures

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.3 - Jul 18
Tracking Status
firefox50 --- fixed

People

(Reporter: rpl, Assigned: rpl)

Details

Attachments

(2 files)

This issue is a follow up for Bug 1283622, its goal is to change the devtools tests that are installing test addons and use the new "addon temporary installation" to prevent any further signing issues when a devtools test addon is added or changed.
Looks good but would be great to fix temporary addons toolbox title before proceeding, that to keep the same assertions.
Comment on attachment 8768847 [details]
Bug 1285289 - add Devtools test addons as Temporary Addons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62864/diff/1-2/
Comment on attachment 8768907 [details]
Bug 1285289 - Use the URL of the addon sourceBundle as the sourceURI of temporary addon.

https://reviewboard.mozilla.org/r/62926/#review59824
Attachment #8768907 - Flags: review?(aswan) → review+
Comment on attachment 8768847 [details]
Bug 1285289 - add Devtools test addons as Temporary Addons.

https://reviewboard.mozilla.org/r/62864/#review59844

Thanks a lot for addressing every single comment!
Attachment #8768847 - Flags: review?(poirot.alex) → review+
Comment on attachment 8768907 [details]
Bug 1285289 - Use the URL of the addon sourceBundle as the sourceURI of temporary addon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62926/diff/1-2/
Comment on attachment 8768847 [details]
Bug 1285289 - add Devtools test addons as Temporary Addons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62864/diff/2-3/
Pushed small tweak (needed to convince Windows to copy the unpacked test addon assets correctly during mach mochitest):

- https://reviewboard.mozilla.org/r/62864/diff/2-3/

Push to try:

- https://treeherder.mozilla.org/#/jobs?repo=try&revision=778667b3ac10
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Iteration: --- → 50.3 - Jul 18
The above try push says that Windows is "happy" now, thanks to the above change to the browser.ini.

checkin-needed added.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/892ef8fbebd9
Use the URL of the addon sourceBundle as the sourceURI of temporary addon. r=aswan
https://hg.mozilla.org/integration/fx-team/rev/1a3c9b20d193
add Devtools test addons as Temporary Addons. r=ochameau
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/892ef8fbebd9
https://hg.mozilla.org/mozilla-central/rev/1a3c9b20d193
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.