1285289 - Install devtools/ test addons as Temporary Addons to prevent signing failures

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This issue is a follow up for Bug 1283622, its goal is to change the devtools tests that are installing test addons and use the new "addon temporary installation" to prevent any further signing issues when a devtools test addon is added or changed.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1285289 - add Devtools test addons as Temporary Addons.

Review commit: https://reviewboard.mozilla.org/r/62864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62864/

Comment 2

[Alexandre Poirot [:ochameau]]

Looks good but would be great to fix temporary addons toolbox title before proceeding, that to keep the same assertions.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1285289 - Use the URL of the addon sourceBundle as the sourceURI of temporary addon.

Review commit: https://reviewboard.mozilla.org/r/62926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62926/

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8768847 [details]
Bug 1285289 - add Devtools test addons as Temporary Addons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62864/diff/1-2/

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8768907 [details]
Bug 1285289 - Use the URL of the addon sourceBundle as the sourceURI of temporary addon.

https://reviewboard.mozilla.org/r/62926/#review59824

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8768847 [details]
Bug 1285289 - add Devtools test addons as Temporary Addons.

https://reviewboard.mozilla.org/r/62864/#review59844

Thanks a lot for addressing every single comment!

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8768907 [details]
Bug 1285289 - Use the URL of the addon sourceBundle as the sourceURI of temporary addon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62926/diff/1-2/

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8768847 [details]
Bug 1285289 - add Devtools test addons as Temporary Addons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62864/diff/2-3/

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

Pushed small tweak (needed to convince Windows to copy the unpacked test addon assets correctly during mach mochitest):

- https://reviewboard.mozilla.org/r/62864/diff/2-3/

Push to try:

- https://treeherder.mozilla.org/#/jobs?repo=try&revision=778667b3ac10

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

The above try push says that Windows is "happy" now, thanks to the above change to the browser.ini.

checkin-needed added.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/892ef8fbebd9
Use the URL of the addon sourceBundle as the sourceURI of temporary addon. r=aswan
https://hg.mozilla.org/integration/fx-team/rev/1a3c9b20d193
add Devtools test addons as Temporary Addons. r=ochameau

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/892ef8fbebd9
https://hg.mozilla.org/mozilla-central/rev/1a3c9b20d193