Closed Bug 1285302 Opened 8 years ago Closed 8 years ago

Add a note describing why `JS::ubi::Size` is not `size_t` DONTBUILD

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

Attachments

(1 file, 1 obsolete file)

Add a note describing why `JS::ubi::Size` is not `size_t` DONTBUILD
1.38 KB, patch
fitzgen
: review+
Details | Diff | Splinter Review 
      No description provided.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Comment on attachment 8768854 [details] [diff] [review]
Add a note describing why `JS::ubi::Size` is not `size_t` DONTBUILD

Review of attachment 8768854 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8768854 - Flags: review?(jimb) → review+
Fix wrong order of 32-bit and 64-bit in the comment.
Attachment #8768879 - Flags: review+
Attachment #8768854 - Attachment is obsolete: true
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0711b79a474
Add a note describing why 'JS::ubi::Size' is not size_t. r=jimb
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e0711b79a474
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: