Add a note describing why `JS::ubi::Size` is not `size_t` DONTBUILD

RESOLVED FIXED in Firefox 50

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Created attachment 8768854 [details] [diff] [review]
Add a note describing why `JS::ubi::Size` is not `size_t` DONTBUILD
Attachment #8768854 - Flags: review?(jimb)
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED

Comment 2

a year ago
Comment on attachment 8768854 [details] [diff] [review]
Add a note describing why `JS::ubi::Size` is not `size_t` DONTBUILD

Review of attachment 8768854 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8768854 - Flags: review?(jimb) → review+
Keywords: checkin-needed
Created attachment 8768879 [details] [diff] [review]
Add a note describing why `JS::ubi::Size` is not `size_t` DONTBUILD

Fix wrong order of 32-bit and 64-bit in the comment.
Attachment #8768879 - Flags: review+
Attachment #8768854 - Attachment is obsolete: true

Comment 4

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0711b79a474
Add a note describing why 'JS::ubi::Size' is not size_t. r=jimb
Keywords: checkin-needed

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e0711b79a474
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.