1285311 - Mark PushSubscriptionOptions.applicationServerKey as SameObject

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Lina Butler [:lina]]

Attachment: appServerKeySameObject.patch

See https://github.com/w3c/push-api/pull/199 and discussion in https://github.com/w3c/push-api/issues/198.

Comment 1

[Andrea Marchesini [:baku]]

Comment on attachment 8768867 [details] [diff] [review]
appServerKeySameObject.patch

Review of attachment 8768867 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/push/PushSubscriptionOptions.cpp
@@ +23,3 @@
>  }
>  
> +PushSubscriptionOptions::~PushSubscriptionOptions() {

{ in a new line

::: dom/push/test/test_register.html
@@ +66,5 @@
>    var pushSubscription;
>    add_task(function* subscribe() {
>      pushSubscription = yield registration.pushManager.subscribe();
> +    is(pushSubscription.options.applicationServerKey, null,
> +      "Subscription should not have an app server key");

here too

::: dom/push/test/test_register_key.html
@@ +111,5 @@
>      });
>      is(pushSubscription.endpoint, "https://example.com/push/1",
>        "Wrong endpoint for subscription with key");
> +    is(pushSubscription.options.applicationServerKey,
> +      pushSubscription.options.applicationServerKey,

identation

Comment 2

[Lina Butler [:lina]]

Attachment: appServerKeySameObject.patch

Fixed style issues, carrying r+.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1b10b75f3fc

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99ccc77aa6fc
Mark `PushSubscriptionOptions.applicationServerKey` as `[SameObject]`. r=baku

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/99ccc77aa6fc