Open Bug 1285313 Opened 9 years ago Updated 5 years ago

[templates][macros] new_<Foo> doesn't count as a Foo constructor

Categories

(Webtools :: Searchfox, defect)

defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: billm, Unassigned)

Details

cx->new_<Foo>() does not show up as a 'use' of Foo's constructor. For instance, it looks like this constructor is unused: http://searchfox.org/mozilla-central/search?q=symbol:_ZN16JSExceptionStateC1EP9JSContext&redirect=false But JS_SaveExceptionState calls it via cx->new_.
This is now sorta fixed. It's still pretty hard to find the uses, but it's less obvious how to improve the situation.

This is a templates factory issue wrapped in a macro for extra complexity. MallocProvider::new_ is defined here which farms out the template factory definition to JS_DECLARE_NEW_METHODS.

Summary: new_<Foo> doesn't count as a Foo constructor → [templates][macros] new_<Foo> doesn't count as a Foo constructor
You need to log in before you can comment on or make changes to this bug.