Closed Bug 1285321 Opened 4 years ago Closed 4 years ago

Bookmarks engine shouldn't reorder roots on first sync

Categories

(Firefox :: Sync, defect, P2)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: Lina, Unassigned)

Details

(Whiteboard: [data-integrity])

The first sync reorders bookmark roots because they're children of the "places" record. This throws (http://searchfox.org/mozilla-central/rev/a7c8e9f3cc323fd707659175a46826ad12899cd1/toolkit/components/places/nsNavBookmarks.cpp#1152-1154), because roots can't be moved: https://gist.github.com/thomcc/2cd1ebcc7080cb7dcc7d0d7ea7ea1a81

As Thom pointed out on IRC, this seems benign; it just creates noise. Unless it would cause issues, we can probably skip roots when applying incoming records.
Priority: -- → P1
Priority: P1 → P2
`PlacesSyncUtils.order` now ignores attempts to reorder roots: http://searchfox.org/mozilla-central/rev/9ec085584d7491ddbaf6574d3732c08511709172/toolkit/components/places/PlacesSyncUtils.jsm#95-99
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.