Bookmarks engine shouldn't reorder roots on first sync

RESOLVED WORKSFORME

Status

()

P2
normal
RESOLVED WORKSFORME
2 years ago
2 years ago

People

(Reporter: lina, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [data-integrity])

(Reporter)

Description

2 years ago
The first sync reorders bookmark roots because they're children of the "places" record. This throws (http://searchfox.org/mozilla-central/rev/a7c8e9f3cc323fd707659175a46826ad12899cd1/toolkit/components/places/nsNavBookmarks.cpp#1152-1154), because roots can't be moved: https://gist.github.com/thomcc/2cd1ebcc7080cb7dcc7d0d7ea7ea1a81

As Thom pointed out on IRC, this seems benign; it just creates noise. Unless it would cause issues, we can probably skip roots when applying incoming records.

Updated

2 years ago
Priority: -- → P1

Updated

2 years ago
Priority: P1 → P2
(Reporter)

Comment 1

2 years ago
`PlacesSyncUtils.order` now ignores attempts to reorder roots: http://searchfox.org/mozilla-central/rev/9ec085584d7491ddbaf6574d3732c08511709172/toolkit/components/places/PlacesSyncUtils.jsm#95-99
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.