if we are going to descend into a frame anyway we may as well store oof data for it so we have the right clip

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

unspecified
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed, firefox50 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
This fixes an assert on try server with bug 1271714.
(Assignee)

Comment 1

2 years ago
Created attachment 8769010 [details] [diff] [review]
patch
Attachment #8769010 - Flags: review?(matt.woodrow)
(Assignee)

Comment 3

2 years ago
Created attachment 8769018 [details] [diff] [review]
patch
Attachment #8769010 - Attachment is obsolete: true
Attachment #8769010 - Flags: review?(matt.woodrow)
Attachment #8769018 - Flags: review?(matt.woodrow)
Attachment #8769018 - Flags: review?(matt.woodrow) → review+

Comment 4

2 years ago
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b82748351785
Store out of flow data for frames we are going to descent into anyways (despite no intersection with the dirty rect) so we have the correct clip for them. r=mattwoodrow

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b82748351785
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
(Assignee)

Comment 6

2 years ago
Comment on attachment 8769018 [details] [diff] [review]
patch

Needed for bug 1276467.

Approval Request Comment
[Feature/regressing bug #]: none
[User impact if declined]: extra cursor gunk in popular web based code editors
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: this patch is safe
[String/UUID change made/needed]: none
Attachment #8769018 - Flags: approval-mozilla-beta?
Attachment #8769018 - Flags: approval-mozilla-aurora?
Comment on attachment 8769018 [details] [diff] [review]
patch

Review of attachment 8769018 [details] [diff] [review]:
-----------------------------------------------------------------

This patch fixes preserve3d asserts and is needed for bug 1276467. Take it in 48 beta 8 and aurora.
Attachment #8769018 - Flags: approval-mozilla-beta?
Attachment #8769018 - Flags: approval-mozilla-beta+
Attachment #8769018 - Flags: approval-mozilla-aurora?
Attachment #8769018 - Flags: approval-mozilla-aurora+

Updated

2 years ago
status-firefox48: --- → affected
status-firefox49: --- → affected

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/87f0c9babed3
status-firefox49: affected → fixed

Comment 9

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/d661b598c1db
status-firefox48: affected → fixed
You need to log in before you can comment on or make changes to this bug.