Closed Bug 1285411 Opened 4 years ago Closed 4 years ago

mark preserve 3d children as "force descend into" before we mark absolute frames so that bug 1285409 applies in a few more cases

Categories

(Core :: Web Painting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox48 --- fixed
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

We can move the marking the preserve3d does a tiny bit earlier, this allows us to save the proper clip in more cases when marking absolute frames.

This fixes some asserts with the patch in bug 1276467 (without the extra hacky patch in that bug).
Attached patch patchSplinter Review
Attachment #8769012 - Flags: review?(matt.woodrow)
Attachment #8769012 - Flags: review?(matt.woodrow) → review+
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd3ca70470c5
Mark preserve 3d children as "force descend into" before we mark absolute frames so that we can save the proper clip for more out of flow frames. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/fd3ca70470c5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment on attachment 8769012 [details] [diff] [review]
patch

Needed for bug 1276467.

Approval Request Comment
[Feature/regressing bug #]: none
[User impact if declined]: extra cursor gunk in popular web based code editors
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: this patch is safe
[String/UUID change made/needed]: none
Attachment #8769012 - Flags: approval-mozilla-beta?
Attachment #8769012 - Flags: approval-mozilla-aurora?
Comment on attachment 8769012 [details] [diff] [review]
patch

Review of attachment 8769012 [details] [diff] [review]:
-----------------------------------------------------------------

This patch fixes preserve3d asserts and is needed for bug 1276467. Take it in 48 beta 8 and aurora.
Attachment #8769012 - Flags: approval-mozilla-beta?
Attachment #8769012 - Flags: approval-mozilla-beta+
Attachment #8769012 - Flags: approval-mozilla-aurora?
Attachment #8769012 - Flags: approval-mozilla-aurora+
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.