1285455 - Firebug theme - element-picker button is too tall in Animation Inspector

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[magicp]

Attachment: firebug-theme-element-picker-in-animationinspector.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160707083343

Steps to reproduce:

1. Start Nightly
2. Open DevTools > Inspector > Animations with Firebug theme


Actual results:

element-picker button is too tall.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=099e2bf3ce03d6eee73577a32b7f0cc84d1f6223&tochange=a308ab434d13684999626b4bac86924ed550fe7a


Expected results:

According to Firefox 48.0b5...
width: 24px;
height: 21px;

Comment 1

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Regression caused at https://hg.mozilla.org/integration/fx-team/rev/a308ab434d13#l1.12

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1285455 - Firebug theme - element-picker button is too tall in Animation Inspector

Review commit: https://reviewboard.mozilla.org/r/63422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63422/

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8769599 [details]
Bug 1285455 - Firebug theme - element-picker button is too tall in Animation Inspector

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63422/diff/1-2/

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8769599 [details]
Bug 1285455 - Firebug theme - element-picker button is too tall in Animation Inspector

https://reviewboard.mozilla.org/r/63422/#review60302

Looks good to me!
Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Just one thing:

The commit message:
Bug 1285455 - Firebug theme - element-picker button is too tall in Animation Inspector r?Honza

... should be:
Bug 1285455 - Firebug theme - element-picker button is too tall in Animation Inspector; r=Honza

That's what we use in DevTools

Honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/2f2c863160a5
Firebug theme - element-picker button is too tall in Animation Inspector. r=Honza

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2f2c863160a5

Comment 9

[Azmina]

I have reproduced this bug with Nightly 50.0a1 (2016-07-07) , on Windows 8.1 64 bit!

This bug's fix is verified on Latest Nightly 50.0a1. 

Build ID : 20160727030230
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0

[bugday-20160727]