If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

--with-system-libvpx flags aren't propagated to WebRTC build

NEW
Unassigned

Status

()

Core
WebRTC
P3
normal
Rank:
21
a year ago
8 days ago

People

(Reporter: Jan Beich, Unassigned)

Tracking

Trunk
Unspecified
Other
Points:
---

Firefox Tracking Flags

(firefox50 affected)

Details

(Reporter)

Description

a year ago
As we're not passing -isystem/usr/local/include by default on DragonFly the build fails in places that don't pass MOZ_LIBVPX_CFLAGS. Linux installs libvpx headers in /usr/include and FreeBSD has the following workaround in old-configure.in:

case "$target_os" in
freebsd*|openbsd*)
# for stuff like -lXshm
    CPPFLAGS="${CPPFLAGS} ${X_CFLAGS}"
    ;;
esac

In file included from media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.h:21:0,
                 from media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/screenshare_layers.h:13,
                 from media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/screenshare_layers.cc:11,
                 from media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_webrtc_vp9/Unified_cpp_codecs_vp90.cpp:2:
dist/system_wrappers/vpx/vpx_decoder.h:3:34: fatal error: vpx/vpx_decoder.h: No such file or directory
compilation terminated.

Updated

a year ago
Rank: 21
Priority: -- → P2
(Reporter)

Comment 1

a year ago
DragonFly can build fine after bug 1288984 as long as X11 is installed under the same prefix as libvpx.
See Also: → bug 1288984
Summary: --with-system-libvpx fails to build on DragonFly → --with-system-libvpx flags aren't propagated to WebRTC build
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.