Closed
Bug 1285522
Opened 9 years ago
Closed 9 years ago
Baldr: Don't DCE operators which can throw
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: bbouvier, Unassigned)
References
Details
Attachments
(1 file)
|
3.55 KB,
patch
|
sunfish
:
review+
|
Details | Diff | Splinter Review |
Found in a spec test \o/; can't enable it yet because of baseline compiler /o\.
This could be enhanced: we could unsetGuard() after ensuring that inputs can't be the one that cause throwing (e.g. in a division, 0), but I'm not sure where the right place to do it is. Plus, LLVM/emscripten should have eliminated dead code in the first place, so Baldr shouldn't need to DCE.
Attachment #8769162 -
Flags: review?(sunfish)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8769162 [details] [diff] [review]
invalid-dce.patch
Review of attachment 8769162 [details] [diff] [review]:
-----------------------------------------------------------------
Yay!
Attachment #8769162 -
Flags: review?(sunfish) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad7e019eff92
Don't DCE opcodes which can throw exceptions at runtime; r=sunfish
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•