1285540 - [RTL] Missing pixels in the arrow from image preview tooltip

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Ada [:adalucinet]]

[Affected versions]:
*reproducible only with RTL builds
- latest Aurora 49.0a1
- latest Nightly 50.0a1

[Affected platforms]:
- Windows 10 64-bit

[Steps to reproduce]:
1. Launch RTL Firefox build.
2. Go to https://www.mozilla.org/en-US/
3. Open Inspector: Ctrl + Shift + C (for Windows & Ubuntu) or Cmd + Opt + C (for Mac OS X) 
4. Hover an img tag in the markup view.

[Expected result]: Tooltip arrow is properly displayed.

[Actual result]: Tooltip arrow has less pixels.

[Regression range]: 
- This is a regression → it's not reproducible with Firefox 48 beta 6 RTL (Build ID: 20160706215822); will investigate further.

[Additional notes]:
- Screenshot → https://i.imgur.com/o4P3IrU.png
- Also reproducible in Netmonitor

Comment 1

[Ada [:adalucinet]]

Regression range:
- Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=df627da479f868c9704d7ac0b1c6aa76fb298150&tochange=9ef45b3ae61d40b772319a314205ddacfe00cff9
- Found commit message: Bug 1266448 - part3: use HTML tooltip for markupview image previews;r=ochameau

Julian, any idea? Thanks in advance!

Comment 2

[Julian Descottes [:jdescottes]]

This is a regression linked to HTML version of the arrow tooltip.

The initial bug is Bug 1267401 where we implemented the HTML arrow tooltip. Now we migrated specific tooltips to use this HTML arrow tooltip in different bugs, Bug 1266448 is one of them. If we want specific bugs for regression tracking:
- markupview image previews : Bug 1266448
- markupview event details : Bug 1266450
- ruleview image & font previews : Bug 1276876
- netmonitor image previews : Bug 1277264

Probably missing some of them. I don't think we will ever ask for an uplift of this issue though so no need to get a very precise regression window here.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1285540 - HTML Tooltip use LTR to position tooltip arrow;

Review commit: https://reviewboard.mozilla.org/r/64058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64058/

Comment 4

[Julian Descottes [:jdescottes]]

I tested this while working on Bug 1286523 and it actually seems to fix this issue.
The approach here is to preserve LTR direction for the tooltip container (and tooltip arrow) and simply restore RTL direction on the tooltip panel.

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8770639 [details]
Bug 1285540 - HTML Tooltip use LTR to position tooltip arrow;

https://reviewboard.mozilla.org/r/64058/#review61040

Fixes the problem for me

Comment 6

[Julian Descottes [:jdescottes]]

Try looks green so far : https://treeherder.mozilla.org/#/jobs?repo=try&revision=d833a38ac634
Only a minor css change, not expecting any regression. Landing.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/6b9dae7e278d
HTML Tooltip: always use LTR direction to position arrow;r=bgrins

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b9dae7e278d

Comment 9

[Ada [:adalucinet]]

Verified fixed with latest Nightly 50.0a1 RTL build, under Windows 10 64-bit.