[RTL] Missing pixels in the arrow from image preview tooltip

VERIFIED FIXED in Firefox 50

Status

P1
normal
VERIFIED FIXED
3 years ago
8 months ago

People

(Reporter: adalucinet, Assigned: jdescottes)

Tracking

({regression})

Trunk
Firefox 50
All
Windows
regression

Firefox Tracking Flags

(firefox47 unaffected, firefox48 unaffected, firefox49 wontfix, firefox50 verified)

Details

(Whiteboard: [reserve-html])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
[Affected versions]:
*reproducible only with RTL builds
- latest Aurora 49.0a1
- latest Nightly 50.0a1

[Affected platforms]:
- Windows 10 64-bit

[Steps to reproduce]:
1. Launch RTL Firefox build.
2. Go to https://www.mozilla.org/en-US/
3. Open Inspector: Ctrl + Shift + C (for Windows & Ubuntu) or Cmd + Opt + C (for Mac OS X) 
4. Hover an img tag in the markup view.

[Expected result]: Tooltip arrow is properly displayed.

[Actual result]: Tooltip arrow has less pixels.

[Regression range]: 
- This is a regression → it's not reproducible with Firefox 48 beta 6 RTL (Build ID: 20160706215822); will investigate further.

[Additional notes]:
- Screenshot → https://i.imgur.com/o4P3IrU.png
- Also reproducible in Netmonitor
(Reporter)

Updated

3 years ago
QA Whiteboard: [qe-dthtml]
Whiteboard: [devtools-html][triage]
Blocks: 1263741
Flags: qe-verify+
QA Contact: alexandra.lucinet
Blocks: 1259121
No longer blocks: 1263741
Priority: -- → P3
Whiteboard: [devtools-html][triage] → [reserve-html]
(Reporter)

Comment 1

3 years ago
Regression range:
- Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=df627da479f868c9704d7ac0b1c6aa76fb298150&tochange=9ef45b3ae61d40b772319a314205ddacfe00cff9
- Found commit message: Bug 1266448 - part3: use HTML tooltip for markupview image previews;r=ochameau

Julian, any idea? Thanks in advance!
Flags: needinfo?(jdescottes)
Keywords: regressionwindow-wanted
(Assignee)

Comment 2

3 years ago
This is a regression linked to HTML version of the arrow tooltip.

The initial bug is Bug 1267401 where we implemented the HTML arrow tooltip. Now we migrated specific tooltips to use this HTML arrow tooltip in different bugs, Bug 1266448 is one of them. If we want specific bugs for regression tracking:
- markupview image previews : Bug 1266448
- markupview event details : Bug 1266450
- ruleview image & font previews : Bug 1276876
- netmonitor image previews : Bug 1277264

Probably missing some of them. I don't think we will ever ask for an uplift of this issue though so no need to get a very precise regression window here.
status-firefox49: affected → wontfix
Flags: needinfo?(jdescottes)
(Assignee)

Updated

3 years ago
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Created attachment 8770639 [details]
Bug 1285540 - HTML Tooltip use LTR to position tooltip arrow;

Review commit: https://reviewboard.mozilla.org/r/64058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64058/
Attachment #8770639 - Flags: review?(bgrinstead)
(Assignee)

Comment 4

3 years ago
I tested this while working on Bug 1286523 and it actually seems to fix this issue.
The approach here is to preserve LTR direction for the tooltip container (and tooltip arrow) and simply restore RTL direction on the tooltip panel.
Iteration: --- → 50.3 - Jul 18
Priority: P3 → P1
Comment on attachment 8770639 [details]
Bug 1285540 - HTML Tooltip use LTR to position tooltip arrow;

https://reviewboard.mozilla.org/r/64058/#review61040

Fixes the problem for me
Attachment #8770639 - Flags: review?(bgrinstead) → review+
(Assignee)

Comment 6

3 years ago
Try looks green so far : https://treeherder.mozilla.org/#/jobs?repo=try&revision=d833a38ac634
Only a minor css change, not expecting any regression. Landing.

Comment 7

3 years ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/6b9dae7e278d
HTML Tooltip: always use LTR direction to position arrow;r=bgrins

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6b9dae7e278d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
(Reporter)

Comment 9

3 years ago
Verified fixed with latest Nightly 50.0a1 RTL build, under Windows 10 64-bit.
Status: RESOLVED → VERIFIED
status-firefox50: fixed → verified
Flags: qe-verify+

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.