1285553 - [desktop_unittest] Don't perform copy dirs step as part of the run-tests action

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect, P1)

Description

[Andrew Halberstadt [:ahal]]

In bug 1262260, we are adding a workflow that aims to do all of the pre-requisite mozharness setup without running tests. We are doing this by not running the 'run-tests' action. However, in desktop_unittest.py, there is some setup stuff that is baked into the 'run-tests' action, namely 'preflight_copydirs' and related methods.

To fix this, we need to pull all this 'copydirs' logic into it's own separate action, so it can be run independently from 'run-tests'.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1285553 - [mozharness] Pull preflight_copydirs into it's own action,

We need to be able to run the copydirs logic in desktop_unittest.py independently
of the 'run-tests' action to enable a smooth interactive debugging workflow.

Review commit: https://reviewboard.mozilla.org/r/63222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63222/

Comment 2

[Armen [:armenzg]]

Comment on attachment 8769252 [details]
Bug 1285553 - [mozharness] Pull preflight_copydirs into it's own action,

https://reviewboard.mozilla.org/r/63222/#review60346

::: testing/mozharness/scripts/desktop_unittest.py:156
(Diff revision 1)
>                  'clobber',
>                  'read-buildbot-config',
>                  'download-and-extract',
>                  'create-virtualenv',
>                  'install',
> +                'copy-dirs',

I like the patch, however, the only part I'm not entirely convinced of is the new action method name.

Most suites indeed copy dirs, however, other suites do more than that.

I was thinking that "stage_files", "pre_execution_setup" or "pre_suite_steps" might be more appropiate.

What do you think?

Comment 3

[Andrew Halberstadt [:ahal]]

https://reviewboard.mozilla.org/r/63222/#review60346

> I like the patch, however, the only part I'm not entirely convinced of is the new action method name.
> 
> Most suites indeed copy dirs, however, other suites do more than that.
> 
> I was thinking that "stage_files", "pre_execution_setup" or "pre_suite_steps" might be more appropiate.
> 
> What do you think?

I like stage-files, I'll make that change. The pre-\* methods have special meaning in mozharness, so I think we should avoid those.

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8769252 [details]
Bug 1285553 - [mozharness] Pull preflight_copydirs into it's own action,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63222/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2a06f7dad6
[mozharness] Pull preflight_copydirs into it's own action, r=armenzg

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4a2a06f7dad6