1285554 - Remove remnants of widget/qt

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Benjamin Smedberg]

With the landing of bug 1282866, we no longer have code to support the qt widget toolkit. At the time I didn't go through the codebase and remove all the references to MOZ_WIDGET_QT, a preprocessor token which will never be defined any more.

Here are all the references: http://searchfox.org/mozilla-central/search?q=moz_widget_qt&case=false&regexp=false&path=

Getting rid of these is mostly (entirely?) a mechanical change:

For something like http://searchfox.org/mozilla-central/rev/f43c9e0ffa92e72dbdbcbf57eecf04a43d46da63/accessible/base/TextAttrs.cpp#662

We need to get rid of the MOZ_WIDGET_QT block, and use #if instead of #elif at line 644.

The more common case is http://searchfox.org/mozilla-central/rev/f43c9e0ffa92e72dbdbcbf57eecf04a43d46da63/browser/base/content/browser.xul#566

Where we just remove the `|| defined(MOZ_WIDGET_QT)` bit.

I'm going to call this a good first bug, because although it's a lot of changes, I don't think there's a lot of hard decisions to make.

Comment 1

[Nicholas Nethercote [inactive]]

I'm going to take this, for a few reasons:

- I like removing unused code.

- I've grappled with widget/-wide changes before, which require updating unused widget/ code, so I'm doubly happy to remove unused widget/ code.

- There's quite a bit more to be removed than just the MOZ_WIDGET_QT conditional blocks. E.g. there are still Qt-specific files remaining, moz.build changes required, etc., so it's harder than it first seems.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Remove remnants of widget/qt

mshal: please review the *.build changes.

dougt: please review everything else.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8769648 [details] [diff] [review]
Remove remnants of widget/qt

LGTM!

Comment 4

[Michael Shal [:mshal]]

Actually it seems there are still some references in old-configure.in:

https://dxr.mozilla.org/mozilla-central/rev/23dc78b7b57e9f91798ea44c242a04e112c37db0/old-configure.in#1778

https://dxr.mozilla.org/mozilla-central/rev/23dc78b7b57e9f91798ea44c242a04e112c37db0/old-configure.in#6154

(so the AC_SUBST(QT_SURFACE_FEATURE) can probably go away as well)

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 8769648 [details] [diff] [review]
Remove remnants of widget/qt

r=lumpy

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: more

> (so the AC_SUBST(QT_SURFACE_FEATURE) can probably go away as well)

Good catch! That AC_SUBST must stay because
gfx/cairo/cairo/src/cairo-features.h.in contains a |@QT_SURFACE_FEATURE@| line,
but a couple of related things in that file can be removed.

I also found some more stuff in widget/ to remove, dougt please check.

Comment 7

[Nicholas Nethercote [inactive]]

BTW I will combine the two patches before landing.

Comment 8

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/749e0ce56c71ae2331f8e0f412124e25a1f147d4
Bug 1285554 - Remove remnants of widget/qt. r=dougt,mshal.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/749e0ce56c71