Closed
Bug 1285556
Opened 8 years ago
Closed 8 years ago
Add an isWebExtension getter to the AddonWrapper
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: rpl, Assigned: rpl)
References
Details
(Whiteboard: triaged)
Attachments
(1 file)
This small change will help other components to recognize when an add-on is a WebExtension, which can be used to treat them differently (e.g. in the remote debugging actors, in the toolbox window or in the about:debugging page). This issue is part of the proposed changes to provide an Addon Debugger with all the features of the Browser Toolbox to the WebExtensions add-ons, but, unlike the Browser Toolbox, all the sources and frames visible are going to be filtered by addon id.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/63164/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63164/
Attachment #8769202 -
Flags: review?(aswan)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8769202 [details] Bug 1285556 - Add isWebExtension getter to the Addon wrapper. https://reviewboard.mozilla.org/r/63164/#review60036
Attachment #8769202 -
Flags: review?(aswan) → review+
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → lgreco
Iteration: --- → 50.3 - Jul 18
|
||
Updated•8 years ago
|
Whiteboard: triaged
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8769202 [details] Bug 1285556 - Add isWebExtension getter to the Addon wrapper. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63164/diff/1-2/
|
|
Assignee | |
Comment 4•8 years ago
|
||
(In reply to Luca Greco [:rpl] from comment #3) > Comment on attachment 8769202 [details] > Bug 1285556 - Add isWebExtension getter to the Addon wrapper. > > Review request updated; see interdiff: > https://reviewboard.mozilla.org/r/63164/diff/1-2/ Patch rebased on a recent fx-team tip.
|
|
Assignee | |
Comment 5•8 years ago
|
||
try push of the rebased patch: - https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a4447ad4b6b
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
Iteration: 50.3 - Jul 18 → 50.4 - Aug 1
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8a9251411581 Add isWebExtension getter to the Addon wrapper. r=aswan
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8a9251411581
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•