Closed Bug 1285572 Opened 3 years ago Closed 3 years ago

Convert load URI event to native method

Categories

(Core :: Widget: Android, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Convert the LOAD_URI event in GeckoEvent to native method calls in GeckoView.
Change ResolveURI to be a member function of nsAppShell, so that code
outside of nsAppShell can use it.
Attachment #8769223 - Flags: review?(snorp)
Keep a pointer to nsPIDOMWindowOuter in GeckoViewSupport so that
GeckoView native method implementations can access the DOM window. This
also lets us simplify GeckoViewSupport::Close by calling
nsPIDOMWindowOuter::ForceClose directly.
Attachment #8769224 - Flags: review?(snorp)
Add a loadUri method in GeckoView that replaces the functionality of the
current LOAD_URI event in GeckoEvent, and make GeckoApp and BrowserApp
use the new call.

The implementation for loadUri differs from the previous implementation
of LOAD_URI by directly calling nsIBrowserDOMWindow::OpenURI, instead of
going through the command-line handler. This more direct approach lets
us get rid of the Fennec command-line handler entirely.
Attachment #8769225 - Flags: review?(snorp)
Remove the LOAD_URI event, which is now obsolete, from GeckoEvent.
Attachment #8769227 - Flags: review?(snorp)
The Fennec CLH is now no longer used for any purpose, so it can be
safely removed.
Attachment #8769228 - Flags: review?(snorp)
Attachment #8769223 - Flags: review?(snorp) → review+
Comment on attachment 8769224 [details] [diff] [review]
Save nsPIDOMWindowOuter in GeckoViewSupport (v1)

Review of attachment 8769224 [details] [diff] [review]:
-----------------------------------------------------------------

Is this going to work ok with e10s?
Attachment #8769224 - Flags: review?(snorp) → review+
Comment on attachment 8769225 [details] [diff] [review]
Add and use loadUri method in GeckoView (v1)

Review of attachment 8769225 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8769225 - Flags: review?(snorp) → review+
Attachment #8769227 - Flags: review?(snorp) → review+
Attachment #8769228 - Flags: review?(snorp) → review+
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #7)
> Comment on attachment 8769224 [details] [diff] [review]
> Save nsPIDOMWindowOuter in GeckoViewSupport (v1)
> 
> Review of attachment 8769224 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is this going to work ok with e10s?

It should since the chrome window under e10s is still in the parent process.
You need to log in before you can comment on or make changes to this bug.