Closed
Bug 1285572
Opened 8 years ago
Closed 8 years ago
Convert load URI event to native method
Categories
(Core Graveyard :: Widget: Android, defect)
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(6 files)
4.38 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
4.27 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
10.53 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
4.61 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
5.72 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
4.29 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Convert the LOAD_URI event in GeckoEvent to native method calls in GeckoView.
Assignee | ||
Comment 1•8 years ago
|
||
Change ResolveURI to be a member function of nsAppShell, so that code outside of nsAppShell can use it.
Attachment #8769223 -
Flags: review?(snorp)
Assignee | ||
Comment 2•8 years ago
|
||
Keep a pointer to nsPIDOMWindowOuter in GeckoViewSupport so that GeckoView native method implementations can access the DOM window. This also lets us simplify GeckoViewSupport::Close by calling nsPIDOMWindowOuter::ForceClose directly.
Attachment #8769224 -
Flags: review?(snorp)
Assignee | ||
Comment 3•8 years ago
|
||
Add a loadUri method in GeckoView that replaces the functionality of the current LOAD_URI event in GeckoEvent, and make GeckoApp and BrowserApp use the new call. The implementation for loadUri differs from the previous implementation of LOAD_URI by directly calling nsIBrowserDOMWindow::OpenURI, instead of going through the command-line handler. This more direct approach lets us get rid of the Fennec command-line handler entirely.
Attachment #8769225 -
Flags: review?(snorp)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8769226 -
Flags: review+
Assignee | ||
Comment 5•8 years ago
|
||
Remove the LOAD_URI event, which is now obsolete, from GeckoEvent.
Attachment #8769227 -
Flags: review?(snorp)
Assignee | ||
Comment 6•8 years ago
|
||
The Fennec CLH is now no longer used for any purpose, so it can be safely removed.
Attachment #8769228 -
Flags: review?(snorp)
Attachment #8769223 -
Flags: review?(snorp) → review+
Comment on attachment 8769224 [details] [diff] [review] Save nsPIDOMWindowOuter in GeckoViewSupport (v1) Review of attachment 8769224 [details] [diff] [review]: ----------------------------------------------------------------- Is this going to work ok with e10s?
Attachment #8769224 -
Flags: review?(snorp) → review+
Comment on attachment 8769225 [details] [diff] [review] Add and use loadUri method in GeckoView (v1) Review of attachment 8769225 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8769225 -
Flags: review?(snorp) → review+
Attachment #8769227 -
Flags: review?(snorp) → review+
Attachment #8769228 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 9•8 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #7) > Comment on attachment 8769224 [details] [diff] [review] > Save nsPIDOMWindowOuter in GeckoViewSupport (v1) > > Review of attachment 8769224 [details] [diff] [review]: > ----------------------------------------------------------------- > > Is this going to work ok with e10s? It should since the chrome window under e10s is still in the parent process.
Comment 10•8 years ago
|
||
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/56b6362b516e Move ResolveURI to nsAppShell; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/a2608d51d577 Save nsPIDOMWindowOuter in GeckoViewSupport; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/00a117d3c5fc Add and use loadUri method in GeckoView; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/e0eb7b52f9a7 Update auto-generated bindings; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/0263ae31e5ec Remove LOAD_URI event; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/d65d3fd104a8 Remove Fennec command-line handler; r=snorp
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/56b6362b516e https://hg.mozilla.org/mozilla-central/rev/a2608d51d577 https://hg.mozilla.org/mozilla-central/rev/00a117d3c5fc https://hg.mozilla.org/mozilla-central/rev/e0eb7b52f9a7 https://hg.mozilla.org/mozilla-central/rev/0263ae31e5ec https://hg.mozilla.org/mozilla-central/rev/d65d3fd104a8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•