1285661 - Add WebGL2 to about:support

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1285661 - Add WebGL2 to about:support. -

Review commit: https://reviewboard.mozilla.org/r/63304/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63304/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8769365 [details]
Bug 1285661 - Add WebGL2 to about:support. -

https://reviewboard.mozilla.org/r/63304/#review60202

This would've been better as two patches. One to refactor things and the next to add the functionality.

::: toolkit/modules/Troubleshoot.jsm:435
(Diff revision 1)
> +    function GetWebGLInfo(contextType) {
> -    let canvas = doc.createElement("canvas");
> +        let canvas = doc.createElement("canvas");
> -    canvas.width = 1;
> +        canvas.width = 1;
> -    canvas.height = 1;
> +        canvas.height = 1;
>  
> -    let gl;
> +        ///////

This //////// idiom is not used elsewhere in this file. Let's drop it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/afbc3291c261
Add WebGL2 to about:support. - r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/5447bbda9f9d
Pare back usage of //// for code block separation.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afbc3291c261
https://hg.mozilla.org/mozilla-central/rev/5447bbda9f9d