Enable hyphenation-dictionary download in Nightly

RESOLVED DUPLICATE of bug 1382589

Status

()

defect
P1
normal
RESOLVED DUPLICATE of bug 1382589
3 years ago
2 years ago

People

(Reporter: k.krish, Assigned: k.krish, Mentored)

Tracking

({stale-bug})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Enable downloading "hyphenation-dictionaries" at runtime in Nightly
(Assignee)

Updated

3 years ago
Assignee: nobody → k.krish
Mentor: s.kaspari
Depends on: 1276588, 1276589
Back when we enabled DLC we just needed to edit mobile/android/confvars.sh, see bug 1233799.

But I think nowadays you do that in mobile/android/moz.configure (Python). There's an example of a Nightly-only flag in bug 1280148.
Comment on attachment 8769805 [details]
Bug 1285752 - Enable hyphenation-dictionary download in Nightly

@glandium: Can you have a look?
Attachment #8769805 - Flags: review?(mh+mozilla)
Comment on attachment 8769805 [details]
Bug 1285752 - Enable hyphenation-dictionary download in Nightly

https://reviewboard.mozilla.org/r/63516/#review60480

::: mobile/android/moz.configure:63
(Diff revision 1)
>  option('--disable-android-apz', env='MOZ_ANDROID_APZ',
>         help='Disable the C++ async pan/zoom code and use the Java version instead')
>  
>  android_apz = depends_if('--disable-android-apz')(lambda _: True)
>  
> +set_config('MOZ_EXCLUDE_HYPHENATION_DICTIONARIES', is_exclude_hyphenation_dictionary_flag_enabled)

You want a set_define too.
Attachment #8769805 - Flags: review?(mh+mozilla)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8769805 [details]
Bug 1285752 - Enable hyphenation-dictionary download in Nightly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63516/diff/1-2/
(Assignee)

Comment 6

3 years ago
https://reviewboard.mozilla.org/r/63516/#review60480

> You want a set_define too.

added set_define
Attachment #8769805 - Flags: review?(s.kaspari) → review?(mh+mozilla)
Comment on attachment 8769805 [details]
Bug 1285752 - Enable hyphenation-dictionary download in Nightly

https://reviewboard.mozilla.org/r/63516/#review61396
Attachment #8769805 - Flags: review?(mh+mozilla) → review+
Great.

@Krish: Let's wait with landing this until we have the dictionaries on the server (bug 1276587) and can do a final test. If everything works then let's land this! :)
Priority: -- → P1

Comment 9

3 years ago
mozreview-review
Comment on attachment 8769805 [details]
Bug 1285752 - Enable hyphenation-dictionary download in Nightly

https://reviewboard.mozilla.org/r/63516/#review90436

This patch doesn't apply anymore. Can you update the patch and let glandium review it?
See above.
Flags: needinfo?(k.krish)
Comment hidden (mozreview-request)
(Assignee)

Comment 12

3 years ago
Updated the patch 

Review Request : https://reviewboard.mozilla.org/r/63516/diff/2-3/
Flags: needinfo?(k.krish)
Comment on attachment 8769805 [details]
Bug 1285752 - Enable hyphenation-dictionary download in Nightly

@glandium: Can you review the new version? :)
Attachment #8769805 - Flags: review?(mh+mozilla)
Attachment #8769805 - Flags: review?(s.kaspari)

Comment 14

2 years ago
mozreview-review
Comment on attachment 8769805 [details]
Bug 1285752 - Enable hyphenation-dictionary download in Nightly

https://reviewboard.mozilla.org/r/63516/#review94146

This is not significantly different enough to need a new review.
Attachment #8769805 - Flags: review?(mh+mozilla) → review+
I'm giving this a last test and land this patch (and the one in bug 1276588).
Thank you for flagging me. This ins now tracked by bug 1382589.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Flags: needinfo?(s.kaspari)
Resolution: --- → DUPLICATE
Duplicate of bug: 1382589
You need to log in before you can comment on or make changes to this bug.